Shorten air bundle route alias

[airbundle] / Controller / ApplicationController.php

diff --git a/Controller/ApplicationController.php b/Controller/ApplicationController.php
index caa190641c1bfa1eb34a2e3c609a37508fafc2d0..8aa7baae88d1473f0fc30d759faf8170deee4af4 100644 (file)
--- a/Controller/ApplicationController.php
+++ b/Controller/ApplicationController.php
@@ -11,8 +11,6 @@
 
 namespace Rapsys\AirBundle\Controller;
 
 
 namespace Rapsys\AirBundle\Controller;
 

-use Doctrine\Bundle\DoctrineBundle\Registry;
-use Doctrine\ORM\EntityManagerInterface;

 use Doctrine\ORM\NoResultException;
 use Doctrine\ORM\ORMInvalidArgumentException;
 use Symfony\Component\Form\FormError;
 use Doctrine\ORM\NoResultException;
 use Doctrine\ORM\ORMInvalidArgumentException;
 use Symfony\Component\Form\FormError;


@@ -46,30 +44,32 @@ class ApplicationController extends AbstractController {
         *
         * @throws \RuntimeException When user has not at least guest role
         */
         *
         * @throws \RuntimeException When user has not at least guest role
         */

-       public function add(Request $request, Registry $doctrine, EntityManagerInterface $manager) {
-               //Prevent non-guest to access here
-               $this->denyAccessUnlessGranted('ROLE_GUEST', null, $this->translator->trans('Unable to access this page without role %role%!', ['%role%' => $this->translator->trans('Guest')]));
+       public function add(Request $request) {
+               //Without guest role
+               if (!$this->checker->isGranted('ROLE_GUEST')) {
+                       //Throw 403
+                       throw $this->createAccessDeniedException($this->translator->trans('Unable to access this page without role %role%!', ['%role%' => $this->translator->trans('Guest')]));
+               }

 
                //Get favorites dances
 
                //Get favorites dances

-               $danceFavorites = $doctrine->getRepository(Dance::class)->findByUserId($this->getUser()->getId());
+               $danceFavorites = $this->doctrine->getRepository(Dance::class)->findByUserId($this->security->getUser()->getId());

 
                //Set dance default
                $danceDefault = !empty($danceFavorites)?current($danceFavorites):null;
 
 
                //Set dance default
                $danceDefault = !empty($danceFavorites)?current($danceFavorites):null;
 

-

                //Get favorites locations
                //Get favorites locations

-               $locationFavorites = $doctrine->getRepository(Location::class)->findByUserId($this->getUser()->getId());
+               $locationFavorites = $this->doctrine->getRepository(Location::class)->findByUserId($this->security->getUser()->getId());

 
                //Set location default
                $locationDefault = !empty($locationFavorites)?current($locationFavorites):null;
 
                //With admin
 
                //Set location default
                $locationDefault = !empty($locationFavorites)?current($locationFavorites):null;
 
                //With admin

-               if ($this->isGranted('ROLE_ADMIN')) {
+               if ($this->checker->isGranted('ROLE_ADMIN')) {

                        //Get dances
                        //Get dances

-                       $dances = $doctrine->getRepository(Dance::class)->findAll();
+                       $dances = $this->doctrine->getRepository(Dance::class)->findAll();

 
                        //Get locations
 
                        //Get locations

-                       $locations = $doctrine->getRepository(Location::class)->findAll();
+                       $locations = $this->doctrine->getRepository(Location::class)->findAll();

                //Without admin
                } else {
                        //Restrict to favorite dances
                //Without admin
                } else {
                        //Restrict to favorite dances


@@ -86,7 +86,7 @@ class ApplicationController extends AbstractController {
                }
 
                //Create ApplicationType form
                }
 
                //Create ApplicationType form

-               $form = $this->createForm('Rapsys\AirBundle\Form\ApplicationType', null, [
+               $form = $this->factory->create('Rapsys\AirBundle\Form\ApplicationType', null, [

                        //Set the action
                        'action' => $this->generateUrl('rapsys_air_application_add'),
                        //Set the form attribute
                        //Set the action
                        'action' => $this->generateUrl('rapsys_air_application_add'),
                        //Set the form attribute


@@ -104,26 +104,32 @@ class ApplicationController extends AbstractController {
                        //Set location favorites
                        'location_favorites' => $locationFavorites,
                        //With user
                        //Set location favorites
                        'location_favorites' => $locationFavorites,
                        //With user

-                       'user' => $this->isGranted('ROLE_ADMIN'),
+                       'user' => $this->checker->isGranted('ROLE_ADMIN'),

                        //Set user choices
                        //Set user choices

-                       'user_choices' => $doctrine->getRepository(User::class)->findAllWithTranslatedGroupAndCivility($this->translator),
+                       'user_choices' => $this->doctrine->getRepository(User::class)->findChoicesAsArray(),

                        //Set default user to current
                        //Set default user to current

-                       'user_default' => $this->getUser()->getId(),
+                       'user_default' => $this->security->getUser()->getId(),

                        //Set default slot to evening
                        //XXX: default to Evening (3)
                        //Set default slot to evening
                        //XXX: default to Evening (3)

-                       'slot_default' => $doctrine->getRepository(Slot::class)->findOneByTitle('Evening')
+                       'slot_default' => $this->doctrine->getRepository(Slot::class)->findOneByTitle('Evening')

                ]);
 
                ]);
 

+               //Set title
+               $this->context['title']['page'] = $this->translator->trans('Application add');
+
+               //Set section
+               $this->context['title']['section'] = $this->translator->trans('Application');
+
+               //Set description
+               $this->context['description'] = $this->translator->trans('Add an application and session');
+

                //Refill the fields in case of invalid form
                $form->handleRequest($request);
 
                //Handle invalid form
                if (!$form->isSubmitted() || !$form->isValid()) {
                //Refill the fields in case of invalid form
                $form->handleRequest($request);
 
                //Handle invalid form
                if (!$form->isSubmitted() || !$form->isValid()) {

-                       //Set title
-                       $title = $this->translator->trans('Application add');
-

                        //Render the view
                        //Render the view

-                       return $this->render('@RapsysAir/application/add.html.twig', ['title' => $title, 'form' => $form->createView()]+$this->context);
+                       return $this->render('@RapsysAir/application/add.html.twig', ['form' => $form->createView()]+$this->context);

                }
 
                //Get data
                }
 
                //Get data


@@ -132,7 +138,7 @@ class ApplicationController extends AbstractController {
                //Protect session fetching
                try {
                        //Fetch session
                //Protect session fetching
                try {
                        //Fetch session

-                       $session = $doctrine->getRepository(Session::class)->findOneByLocationSlotDate($data['location'], $data['slot'], $data['date']);
+                       $session = $this->doctrine->getRepository(Session::class)->findOneByLocationSlotDate($data['location'], $data['slot'], $data['date']);

                //Catch no session case
                } catch (NoResultException $e) {
                        //Create the session
                //Catch no session case
                } catch (NoResultException $e) {
                        //Create the session


@@ -156,7 +162,7 @@ class ApplicationController extends AbstractController {
                        $session->setLength(new \DateTime('06:00:00'));
 
                        //Check if admin
                        $session->setLength(new \DateTime('06:00:00'));
 
                        //Check if admin

-                       if ($this->isGranted('ROLE_ADMIN')) {
+                       if ($this->checker->isGranted('ROLE_ADMIN')) {

                                //Check if morning
                                if ($slot == 'Morning') {
                                        //Set begin at 9h
                                //Check if morning
                                if ($slot == 'Morning') {
                                        //Set begin at 9h


@@ -167,19 +173,22 @@ class ApplicationController extends AbstractController {
                                //Check if afternoon
                                } elseif ($slot == 'Afternoon') {
                                        //Set begin at 18h
                                //Check if afternoon
                                } elseif ($slot == 'Afternoon') {
                                        //Set begin at 18h

-                                       $session->setBegin(new \DateTime('14:00:00'));
+                                       $session->setBegin(new \DateTime('15:30:00'));

 
                                        //Set length at 5h
 
                                        //Set length at 5h

-                                       $session->setLength(new \DateTime('05:00:00'));
+                                       $session->setLength(new \DateTime('05:30:00'));

                                //Check if evening
                                } elseif ($slot == 'Evening') {
                                        //Set begin at 19h00
                                //Check if evening
                                } elseif ($slot == 'Evening') {
                                        //Set begin at 19h00

-                                       $session->setBegin(new \DateTime('19:00:00'));
+                                       $session->setBegin(new \DateTime('19:30:00'));
+
+                                       //Set length at 5h
+                                       $session->setLength(new \DateTime('05:30:00'));

 
                                        //Check if next day is premium
                                        if ($premium) {
                                                //Set length at 7h
 
                                        //Check if next day is premium
                                        if ($premium) {
                                                //Set length at 7h

-                                               $session->setLength(new \DateTime('07:00:00'));
+                                               $session->setLength(new \DateTime('06:30:00'));

                                        }
                                //Check if after
                                } else {
                                        }
                                //Check if after
                                } else {


@@ -331,46 +340,40 @@ class ApplicationController extends AbstractController {
                                //Add error in flash message
                                $this->addFlash('error', $this->translator->trans('Session on %date% %location% %slot% not yet supported', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
 
                                //Add error in flash message
                                $this->addFlash('error', $this->translator->trans('Session on %date% %location% %slot% not yet supported', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
 

-                               //Set title
-                               $title = $this->translator->trans('Application add');
-

                                //Render the view
                                //Render the view

-                               return $this->render('@RapsysAir/application/add.html.twig', ['title' => $title, 'form' => $form->createView()]+$this->context);
+                               return $this->render('@RapsysAir/application/add.html.twig', ['form' => $form->createView()]+$this->context);

                        }
 
                        //Check if admin
                        }
 
                        //Check if admin

-                       if (!$this->isGranted('ROLE_ADMIN') && $session->getStart() < new \DateTime('00:00:00')) {
+                       if (!$this->checker->isGranted('ROLE_ADMIN') && $session->getStart() < new \DateTime('00:00:00')) {

                                //Add error in flash message
                                $this->addFlash('error', $this->translator->trans('Session in the past on %date% %location% %slot% not yet supported', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
 
                                //Add error in flash message
                                $this->addFlash('error', $this->translator->trans('Session in the past on %date% %location% %slot% not yet supported', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
 

-                               //Set title
-                               $title = $this->translator->trans('Application add');
-

                                //Render the view
                                //Render the view

-                               return $this->render('@RapsysAir/application/add.html.twig', ['title' => $title, 'form' => $form->createView()]+$this->context);
+                               return $this->render('@RapsysAir/application/add.html.twig', ['form' => $form->createView()]+$this->context);

                        }
 
                        //Queue session save
                        }
 
                        //Queue session save

-                       $manager->persist($session);
+                       $this->manager->persist($session);

 
                        //Flush to get the ids
 
                        //Flush to get the ids

-                       #$manager->flush();
+                       #$this->manager->flush();

 
                        $this->addFlash('notice', $this->translator->trans('Session on %date% %location% %slot% created', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
                }
 
                //Set user
 
                        $this->addFlash('notice', $this->translator->trans('Session on %date% %location% %slot% created', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
                }
 
                //Set user

-               $user = $this->getUser();
+               $user = $this->security->getUser();

 
                //Replace with requested user for admin
 
                //Replace with requested user for admin

-               if ($this->isGranted('ROLE_ADMIN') && !empty($data['user'])) {
-                       $user = $this->getDoctrine()->getRepository(User::class)->findOneById($data['user']);
+               if ($this->checker->isGranted('ROLE_ADMIN') && !empty($data['user'])) {
+                       $user = $this->doctrine->getRepository(User::class)->findOneById($data['user']);

                }
 
                //Protect application fetching
                try {
                        //Retrieve application
                }
 
                //Protect application fetching
                try {
                        //Retrieve application

-                       $application = $doctrine->getRepository(Application::class)->findOneBySessionUser($session, $user);
+                       $application = $this->doctrine->getRepository(Application::class)->findOneBySessionUser($session, $user);

 
                        //Add warning in flash message
                        $this->addFlash('warning', $this->translator->trans('Application on %date% %location% %slot% already exists', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
 
                        //Add warning in flash message
                        $this->addFlash('warning', $this->translator->trans('Application on %date% %location% %slot% already exists', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));


@@ -386,13 +389,13 @@ class ApplicationController extends AbstractController {
                        $session->setUpdated(new \DateTime('now'));
 
                        //Queue session save
                        $session->setUpdated(new \DateTime('now'));
 
                        //Queue session save

-                       $manager->persist($session);
+                       $this->manager->persist($session);

 
                        //Queue application save
 
                        //Queue application save

-                       $manager->persist($application);
+                       $this->manager->persist($application);

 
                        //Flush to get the ids
 
                        //Flush to get the ids

-                       $manager->flush();
+                       $this->manager->flush();

 
                        //Add notice in flash message
                        $this->addFlash('notice', $this->translator->trans('Application on %date% %location% %slot% created', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));
 
                        //Add notice in flash message
                        $this->addFlash('notice', $this->translator->trans('Application on %date% %location% %slot% created', ['%location%' => $this->translator->trans('at '.$data['location']), '%slot%' => $this->translator->trans('the '.strtolower(strval($data['slot']))), '%date%' => $data['date']->format('Y-m-d')]));