Annotate changelog bug being closed.

[youtubedl] / youtube_dl / downloader / mplayer.py

diff --git a/youtube_dl/downloader/mplayer.py b/youtube_dl/downloader/mplayer.py
index c53195da0c9471d55a61b53b1041e05ee209697e..72cef30eaf3718ad8932814a627042cc0bdff361 100644 (file)
--- a/youtube_dl/downloader/mplayer.py
+++ b/youtube_dl/downloader/mplayer.py
@@ -4,8 +4,8 @@ import os
 import subprocess
 
 from .common import FileDownloader
 import subprocess
 
 from .common import FileDownloader

-from ..compat import compat_subprocess_get_DEVNULL

 from ..utils import (
 from ..utils import (

+    check_executable,

     encodeFilename,
 )
 
     encodeFilename,
 )
 


@@ -20,11 +20,7 @@ class MplayerFD(FileDownloader):
             'mplayer', '-really-quiet', '-vo', 'null', '-vc', 'dummy',
             '-dumpstream', '-dumpfile', tmpfilename, url]
         # Check for mplayer first
             'mplayer', '-really-quiet', '-vo', 'null', '-vc', 'dummy',
             '-dumpstream', '-dumpfile', tmpfilename, url]
         # Check for mplayer first

-        try:
-            subprocess.call(
-                ['mplayer', '-h'],
-                stdout=compat_subprocess_get_DEVNULL(), stderr=subprocess.STDOUT)
-        except (OSError, IOError):
+        if not check_executable('mplayer', ['-h']):

             self.report_error('MMS or RTSP download detected but "%s" could not be run' % args[0])
             return False
 
             self.report_error('MMS or RTSP download detected but "%s" could not be run' % args[0])
             return False