Update changelog.

[youtubedl] / youtube_dl / extractor / collegehumor.py

diff --git a/youtube_dl/extractor/collegehumor.py b/youtube_dl/extractor/collegehumor.py
index d10b7bd0cda2161838e83da741fe7a2f6c88f575..10c925dfe1c7d44d7d1f6abe6a72b79d12230abf 100644 (file)
--- a/youtube_dl/extractor/collegehumor.py
+++ b/youtube_dl/extractor/collegehumor.py
@@ -4,6 +4,7 @@ import json
 import re
 
 from .common import InfoExtractor
 import re
 
 from .common import InfoExtractor

+from ..utils import int_or_none

 
 
 class CollegeHumorIE(InfoExtractor):
 
 
 class CollegeHumorIE(InfoExtractor):


@@ -11,24 +12,45 @@ class CollegeHumorIE(InfoExtractor):
 
     _TESTS = [{
         'url': 'http://www.collegehumor.com/video/6902724/comic-con-cosplay-catastrophe',
 
     _TESTS = [{
         'url': 'http://www.collegehumor.com/video/6902724/comic-con-cosplay-catastrophe',

-        'file': '6902724.mp4',

         'md5': 'dcc0f5c1c8be98dc33889a191f4c26bd',
         'info_dict': {
         'md5': 'dcc0f5c1c8be98dc33889a191f4c26bd',
         'info_dict': {

+            'id': '6902724',
+            'ext': 'mp4',

             'title': 'Comic-Con Cosplay Catastrophe',
             'title': 'Comic-Con Cosplay Catastrophe',

-            'description': 'Fans get creative this year at San Diego.  Too',
+            'description': 'Fans get creative this year',

             'age_limit': 13,
         },
     },
     {
         'url': 'http://www.collegehumor.com/video/3505939/font-conference',
             'age_limit': 13,
         },
     },
     {
         'url': 'http://www.collegehumor.com/video/3505939/font-conference',

-        'file': '3505939.mp4',

         'md5': '72fa701d8ef38664a4dbb9e2ab721816',
         'info_dict': {
         'md5': '72fa701d8ef38664a4dbb9e2ab721816',
         'info_dict': {

+            'id': '3505939',
+            'ext': 'mp4',

             'title': 'Font Conference',
             'title': 'Font Conference',

-            'description': 'This video wasn\'t long enough, so we made it double-spaced.',
+            'description': 'This video wasn\'t long enough,',

             'age_limit': 10,
             'age_limit': 10,

+            'duration': 179,

         },
         },

-    }]
+    },
+    # embedded youtube video
+    {
+        'url': 'http://www.collegehumor.com/embed/6950457',
+        'info_dict': {
+            'id': 'W5gMp3ZjYg4',
+            'ext': 'mp4',
+            'title': 'Funny Dogs Protecting Babies Compilation 2014 [NEW HD]',
+            'uploader': 'Funnyplox TV',
+            'uploader_id': 'funnyploxtv',
+            'description': 'md5:7ded37421526d54afdf005e25bc2b7a3',
+            'upload_date': '20140128',
+        },
+        'params': {
+            'skip_download': True,
+        },
+        'add_ie': ['Youtube'],
+    },
+    ]

 
     def _real_extract(self, url):
         mobj = re.match(self._VALID_URL, url)
 
     def _real_extract(self, url):
         mobj = re.match(self._VALID_URL, url)


@@ -38,6 +60,12 @@ class CollegeHumorIE(InfoExtractor):
         data = json.loads(self._download_webpage(
             jsonUrl, video_id, 'Downloading info JSON'))
         vdata = data['video']
         data = json.loads(self._download_webpage(
             jsonUrl, video_id, 'Downloading info JSON'))
         vdata = data['video']

+        if vdata.get('youtubeId') is not None:
+            return {
+                '_type': 'url',
+                'url': vdata['youtubeId'],
+                'ie_key': 'Youtube',
+            }

 
         AGE_LIMITS = {'nc17': 18, 'r': 18, 'pg13': 13, 'pg': 10, 'g': 0}
         rating = vdata.get('rating')
 
         AGE_LIMITS = {'nc17': 18, 'r': 18, 'pg13': 13, 'pg': 10, 'g': 0}
         rating = vdata.get('rating')


@@ -49,7 +77,7 @@ class CollegeHumorIE(InfoExtractor):
         PREFS = {'high_quality': 2, 'low_quality': 0}
         formats = []
         for format_key in ('mp4', 'webm'):
         PREFS = {'high_quality': 2, 'low_quality': 0}
         formats = []
         for format_key in ('mp4', 'webm'):

-            for qname, qurl in vdata[format_key].items():
+            for qname, qurl in vdata.get(format_key, {}).items():

                 formats.append({
                     'format_id': format_key + '_' + qname,
                     'url': qurl,
                 formats.append({
                     'format_id': format_key + '_' + qname,
                     'url': qurl,


@@ -58,6 +86,8 @@ class CollegeHumorIE(InfoExtractor):
                 })
         self._sort_formats(formats)
 
                 })
         self._sort_formats(formats)
 

+        duration = int_or_none(vdata.get('duration'), 1000)
+

         return {
             'id': video_id,
             'title': vdata['title'],
         return {
             'id': video_id,
             'title': vdata['title'],


@@ -65,4 +95,5 @@ class CollegeHumorIE(InfoExtractor):
             'thumbnail': vdata.get('thumbnail'),
             'formats': formats,
             'age_limit': age_limit,
             'thumbnail': vdata.get('thumbnail'),
             'formats': formats,
             'age_limit': age_limit,

+            'duration': duration,

         }
         }