X-Git-Url: https://git.rapsys.eu/packbundle/blobdiff_plain/63f158466030cd436f11864e5494885a4f3ba11d..8989e866f7ba949de31856943049d6f908fdc46d:/DependencyInjection/Configuration.php

diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
index dde458d..7217e98 100644
--- a/DependencyInjection/Configuration.php
+++ b/DependencyInjection/Configuration.php
@@ -1,4 +1,13 @@
-<?php
+<?php declare(strict_types=1);
+
+/*
+ * This file is part of the Rapsys PackBundle package.
+ *
+ * (c) Raphaël Gertz <symfony@rapsys.eu>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
 
 namespace Rapsys\PackBundle\DependencyInjection;
 
@@ -6,95 +15,86 @@ use Symfony\Component\Config\Definition\Builder\TreeBuilder;
 use Symfony\Component\Config\Definition\ConfigurationInterface;
 use Symfony\Component\Process\ExecutableFinder;
 
+use Rapsys\PackBundle\RapsysPackBundle;
+
 /**
  * This is the class that validates and merges configuration from your app/config files.
  *
- * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/configuration.html}
+ * @link http://symfony.com/doc/current/cookbook/bundles/configuration.html}
+ *
+ * {@inheritdoc}
  */
 class Configuration implements ConfigurationInterface {
-	//The project dir
-	private $projectDir;
-
-	//Constructor required to derivate prefix from kernel.project_dir
-	public function __construct($projectDir) {
-		$this->projectDir = $projectDir;
-	}
-
 	/**
 	 * {@inheritdoc}
 	 */
-	public function getConfigTreeBuilder() {
+	public function getConfigTreeBuilder(): TreeBuilder {
 		//Get TreeBuilder object
-		$treeBuilder = new TreeBuilder('rapsys_pack');
+		$treeBuilder = new TreeBuilder(RapsysPackBundle::getAlias());
 
 		//Get ExecutableFinder object
 		$finder = new ExecutableFinder();
 
-		#TODO: see how we deal with asset url generation: see Rapsys/PackBundle/Twig/PackTokenParser.php +243
-		#framework:
-		#    assets:
-		#        packages:
-		#            rapsys_pack:
-		#                base_path: '/'
-		#                version: ~
-		#
-		## Force cache disable to regenerate resources each time
-		##twig:
-		##    cache: ~
-
-		//TODO: see https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php for default value and description
-		//TODO: see http://symfony.com/doc/current/components/config/definition.html
-		//TODO: see https://github.com/symfony/assetic-bundle/blob/master/DependencyInjection/Configuration.php#L63
-		//TODO: use bin/console config:dump-reference to dump class infos
-
 		//The bundle default values
 		$defaults = [
 			'config' => [
-				'prefix' => $this->projectDir,
 				'name' => 'asset_url',
 				'scheme' => 'https://',
 				'timeout' => (int)ini_get('default_socket_timeout'),
-				'agent' => (string)ini_get('user_agent')?:'rapsys_pack/0.0.2',
+				'agent' => (string)ini_get('user_agent')?:'rapsys_pack/0.2.0',
 				'redirect' => 5
 			],
 			'output' => [
-				'css' => 'css/*.pack.css',
-				'js' => 'js/*.pack.js',
-				'img' => 'img/*.pack.jpg'
+				'css' => '@RapsysPack/css/*.pack.css',
+				'js' =>  '@RapsysPack/js/*.pack.js',
+				'img' => '@RapsysPack/img/*.pack.jpg'
 			],
 			'filters' => [
 				'css' => [
-					'class' => 'Rapsys\PackBundle\Twig\Filter\CPackFilter',
-					'args' => [
-						$finder->find('cpack', '/usr/local/bin/cpack'),
-						'minify'
+					0 => [
+						'class' => 'Rapsys\PackBundle\Filter\CPackFilter',
+						'args' => [
+							$finder->find('cpack', '/usr/local/bin/cpack'),
+							'minify'
+						]
 					]
 				],
 				'js' => [
-					'class' => 'Rapsys\PackBundle\Twig\Filter\JPackFilter',
-					'args' => [
-						$finder->find('jpack', '/usr/local/bin/jpack'),
-						'best'
+					0 => [
+						'class' => 'Rapsys\PackBundle\Filter\JPackFilter',
+						'args' => [
+							$finder->find('jpack', '/usr/local/bin/jpack'),
+							'best'
+						]
 					]
 				],
 				'img' => [
-					'class' => 'Rapsys\PackBundle\Twig\Filter\IPackFilter',
-					'args' => []
+					0 => [
+						'class' => 'Rapsys\PackBundle\Filter\IPackFilter',
+						'args' => []
+					]
 				],
 			]
 		];
 
-		//Here we define the parameters that are allowed to configure the bundle.
+		/**
+		 * Defines parameters allowed to configure the bundle
+		 *
+		 * @link https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
+		 * @link http://symfony.com/doc/current/components/config/definition.html
+		 * @link https://github.com/symfony/assetic-bundle/blob/master/DependencyInjection/Configuration.php#L63
+		 *
+		 * @see php bin/console config:dump-reference rapsys_pack to dump default config
+		 * @see php bin/console debug:config rapsys_pack to dump config
+		 */
 		$treeBuilder
 			//Parameters
 			->getRootNode()
-				#->cannotBeEmpty()
 				->addDefaultsIfNotSet()
 				->children()
 					->arrayNode('config')
 						->addDefaultsIfNotSet()
 						->children()
-							->scalarNode('prefix')->cannotBeEmpty()->defaultValue($defaults['config']['prefix'])->end()
 							->scalarNode('name')->cannotBeEmpty()->defaultValue($defaults['config']['name'])->end()
 							->scalarNode('scheme')->cannotBeEmpty()->defaultValue($defaults['config']['scheme'])->end()
 							->integerNode('timeout')->min(0)->max(300)->defaultValue($defaults['config']['timeout'])->end()
@@ -114,55 +114,67 @@ class Configuration implements ConfigurationInterface {
 						->addDefaultsIfNotSet()
 						->children()
 							->arrayNode('css')
-								#XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+								/**
+								 * Undocumented
+								 *
+								 * @see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+								 */
 								->addDefaultChildrenIfNoneSet()
 								->arrayPrototype()
 									->children()
 										->scalarNode('class')
 											->isRequired()
 											->cannotBeEmpty()
-											->defaultValue($defaults['filters']['css']['class'])
+											->defaultValue($defaults['filters']['css'][0]['class'])
 										->end()
 										->arrayNode('args')
-											/*->isRequired()*/
-											->treatNullLike(array())
-											->defaultValue($defaults['filters']['css']['args'])
+											//->isRequired()
+											->treatNullLike([])
+											->defaultValue($defaults['filters']['css'][0]['args'])
 											->scalarPrototype()->end()
 										->end()
 									->end()
 								->end()
 							->end()
 							->arrayNode('js')
-								#XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+								/**
+								 * Undocumented
+								 *
+								 * @see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+								 */
 								->addDefaultChildrenIfNoneSet()
 								->arrayPrototype()
 									->children()
 										->scalarNode('class')
 											->isRequired()
 											->cannotBeEmpty()
-											->defaultValue($defaults['filters']['js']['class'])
+											->defaultValue($defaults['filters']['js'][0]['class'])
 										->end()
 										->arrayNode('args')
-											->treatNullLike(array())
-											->defaultValue($defaults['filters']['js']['args'])
+											->treatNullLike([])
+											->defaultValue($defaults['filters']['js'][0]['args'])
 											->scalarPrototype()->end()
 										->end()
 									->end()
 								->end()
 							->end()
 							->arrayNode('img')
-								#XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+								/**
+								 * Undocumented
+								 *
+								 * @see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+								 */
 								->addDefaultChildrenIfNoneSet()
 								->arrayPrototype()
 									->children()
 										->scalarNode('class')
 											->isRequired()
 											->cannotBeEmpty()
-											->defaultValue($defaults['filters']['img']['class'])
+											->defaultValue($defaults['filters']['img'][0]['class'])
 										->end()
 										->arrayNode('args')
-											->treatNullLike(array())
-											->defaultValue($defaults['filters']['img']['args'])
+											->treatNullLike([])
+											->defaultValue($defaults['filters']['img'][0]['args'])
 											->scalarPrototype()->end()
 										->end()
 									->end()