From: Raphaƫl Gertz Date: Thu, 29 Feb 2024 13:14:02 +0000 (+0100) Subject: Php 8.x constructor style X-Git-Tag: 0.4.0~39 X-Git-Url: https://git.rapsys.eu/packbundle/commitdiff_plain/1e337bacd356579f4fea5b1a0a34d7ca40e686cb?hp=55a896d78af2f339ce675640248c2a6a05f7cb7f Php 8.x constructor style Cleanup --- diff --git a/Util/SluggerUtil.php b/Util/SluggerUtil.php index fc3f462..d88cdfd 100644 --- a/Util/SluggerUtil.php +++ b/Util/SluggerUtil.php @@ -12,36 +12,40 @@ namespace Rapsys\PackBundle\Util; /** - * Helps manage string conversions + * Manages string conversions */ class SluggerUtil { - //The secret parameter - private $secret; - - //The alpha array - private $alpha; + /** + * The alpha array + */ + protected array $alpha; - //The rev array - private $rev; + /** + * The rev array + */ + protected array $rev; - //The alpha array key number - private $count; + /** + * The alpha array key number + */ + protected int $count; - //The offset reduced from secret - private $offset; + /** + * The offset reduced from secret + */ + protected int $offset; /** * Construct slugger util * + * TODO: use a recipe to generate in .env.local an env variable RAPSYSPACK_SECRET="ayl[...]z9w" + * * @todo Add a command to generate alpha array or generate it on first run with cache storage ? * @todo Use Cache like in calendar controller through FilesystemAdapter * * @param string $secret The secret string */ - public function __construct(string $secret) { - //Set secret - $this->secret = $secret; - + public function __construct(protected string $secret) { /** * Pseudo-random alphabet * @xxx use array flip and keys to workaround php "smart" that cast range('0', '9') as int instead of string