From: Raphaƫl Gertz Date: Wed, 27 Nov 2019 16:38:30 +0000 (+0100) Subject: Add todo about new symfony 4.4 getPublicDir bundle member function X-Git-Tag: 0.1.4~5 X-Git-Url: https://git.rapsys.eu/packbundle/commitdiff_plain/a951f3cdbb523bf6598477d87d49aa454ab4818d?hp=f86a3843cac9cddecd718697c8ce401fa6637dc3 Add todo about new symfony 4.4 getPublicDir bundle member function --- diff --git a/Asset/PathPackage.php b/Asset/PathPackage.php index 5fa69e2..1a975c5 100644 --- a/Asset/PathPackage.php +++ b/Asset/PathPackage.php @@ -31,6 +31,8 @@ class PathPackage extends BasePackage { } /** + * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ? + * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure * {@inheritdoc} */ public function getUrl($path) { diff --git a/Twig/PackTokenParser.php b/Twig/PackTokenParser.php index 9fffebb..c4bbe4c 100644 --- a/Twig/PackTokenParser.php +++ b/Twig/PackTokenParser.php @@ -328,6 +328,9 @@ class PackTokenParser extends AbstractTokenParser { * @param \Exception prev The previous exception * * @return string The resolved file path + * + * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ? + * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure */ public function getLocated($file, int $lineno = 0, Source $source = null, \Exception $prev = null) { /*TODO: add a @jquery magic feature ?