From a951f3cdbb523bf6598477d87d49aa454ab4818d Mon Sep 17 00:00:00 2001 From: =?utf8?q?Rapha=C3=ABl=20Gertz?= Date: Wed, 27 Nov 2019 17:38:30 +0100 Subject: [PATCH] Add todo about new symfony 4.4 getPublicDir bundle member function --- Asset/PathPackage.php | 2 ++ Twig/PackTokenParser.php | 3 +++ 2 files changed, 5 insertions(+) diff --git a/Asset/PathPackage.php b/Asset/PathPackage.php index 5fa69e2..1a975c5 100644 --- a/Asset/PathPackage.php +++ b/Asset/PathPackage.php @@ -31,6 +31,8 @@ class PathPackage extends BasePackage { } /** + * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ? + * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure * {@inheritdoc} */ public function getUrl($path) { diff --git a/Twig/PackTokenParser.php b/Twig/PackTokenParser.php index 9fffebb..c4bbe4c 100644 --- a/Twig/PackTokenParser.php +++ b/Twig/PackTokenParser.php @@ -328,6 +328,9 @@ class PackTokenParser extends AbstractTokenParser { * @param \Exception prev The previous exception * * @return string The resolved file path + * + * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ? + * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure */ public function getLocated($file, int $lineno = 0, Source $source = null, \Exception $prev = null) { /*TODO: add a @jquery magic feature ? -- 2.41.1