X-Git-Url: https://git.rapsys.eu/userbundle/blobdiff_plain/bab59a4b88a081a7a27a53b4559d74e63b68db92..c9e609cd2dcfd79a9a714d2a1f5acfe699bb1c81:/Controller/DefaultController.php?ds=sidebyside diff --git a/Controller/DefaultController.php b/Controller/DefaultController.php index d3c2a3f..f364144 100644 --- a/Controller/DefaultController.php +++ b/Controller/DefaultController.php @@ -2,375 +2,949 @@ namespace Rapsys\UserBundle\Controller; -use Symfony\Bundle\FrameworkBundle\Controller\Controller; +use Doctrine\Bundle\DoctrineBundle\Registry; +use Doctrine\ORM\EntityManagerInterface; +use Psr\Log\LoggerInterface; +use Symfony\Bridge\Twig\Mime\TemplatedEmail; +use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; +use Symfony\Component\DependencyInjection\ContainerInterface; +use Symfony\Component\Form\FormError; use Symfony\Component\HttpFoundation\Request; +use Symfony\Component\HttpKernel\Exception\BadRequestHttpException; +use Symfony\Component\Mailer\Exception\TransportExceptionInterface; +use Symfony\Component\Mailer\MailerInterface; +use Symfony\Component\Mime\Address; +use Symfony\Component\Routing\Exception\MethodNotAllowedException; +use Symfony\Component\Routing\Exception\ResourceNotFoundException; use Symfony\Component\Routing\Generator\UrlGeneratorInterface; +use Symfony\Component\Routing\RequestContext; +use Symfony\Component\Routing\RouterInterface; +use Symfony\Component\Security\Core\Authentication\Token\UsernamePasswordToken; use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface; use Symfony\Component\Security\Http\Authentication\AuthenticationUtils; -use Symfony\Component\Form\FormError; -use Rapsys\UserBundle\Utils\Slugger; - -class DefaultController extends Controller { - public function loginAction(Request $request, AuthenticationUtils $authenticationUtils) { - //Get template - $template = $this->container->getParameter(($alias = $this->getAlias()).'.login.template'); - //Get context - $context = $this->container->getParameter($alias.'.login.context'); - - //Create the form according to the FormType created previously. - //And give the proper parameters - $form = $this->createForm('Rapsys\UserBundle\Form\LoginType', null, array( - // To set the action use $this->generateUrl('route_identifier') - 'action' => $this->generateUrl('rapsys_user_login'), - 'method' => 'POST' - )); +use Symfony\Component\Translation\TranslatorInterface; - //Get the login error if there is one - if ($error = $authenticationUtils->getLastAuthenticationError()) { - //Get translator - $trans = $this->get('translator'); +use Rapsys\PackBundle\Util\SluggerUtil; +use Rapsys\UserBundle\RapsysUserBundle; - //Get translated error - $error = $trans->trans($error->getMessageKey()); +class DefaultController extends AbstractController { + //Config array + protected $config; - //Add error message to mail field - $form->get('mail')->addError(new FormError($error)); + //Translator instance + protected $translator; + + /** + * Constructor + * + * @TODO: move all canonical and other view related stuff in an user AbstractController like in RapsysAir render feature !!!! + * @TODO: add resetpassword ? with $this->denyAccessUnlessGranted('IS_AUTHENTICATED_FULLY'); https://symfony.com/doc/current/security/remember_me.html + * + * @param ContainerInterface $container The containter instance + * @param RouterInterface $router The router instance + * @param TranslatorInterface $translator The translator instance + */ + public function __construct(ContainerInterface $container, RouterInterface $router, TranslatorInterface $translator) { + //Retrieve config + $this->config = $container->getParameter(self::getAlias()); + + //Set the translator + $this->translator = $translator; + + //Get request stack + $stack = $container->get('request_stack'); + + //Get current request + $request = $stack->getCurrentRequest(); + + //Get current locale + $currentLocale = $request->getLocale(); + + //Set locale + $this->config['context']['locale'] = str_replace('_', '-', $currentLocale); + + //Set translate array + $translates = []; + + //Look for keys to translate + if (!empty($this->config['translate'])) { + //Iterate on keys to translate + foreach($this->config['translate'] as $translate) { + //Set tmp + $tmp = null; + //Iterate on keys + foreach(array_reverse(explode('.', $translate)) as $curkey) { + $tmp = array_combine([$curkey], [$tmp]); + } + //Append tree + $translates = array_replace_recursive($translates, $tmp); + } } - //Last username entered by the user - if ($lastUsername = $authenticationUtils->getLastUsername()) { - $form->get('mail')->setData($lastUsername); + //Inject every requested route in view and mail context + foreach($this->config as $tag => $current) { + //Look for entry with title subkey + if (!empty($current['title'])) { + //Translate title value + $this->config[$tag]['title'] = $translator->trans($current['title']); + } + + //Look for entry with route subkey + if (!empty($current['route'])) { + //Generate url for both view and mail + foreach(['view', 'mail'] as $view) { + //Check that context key is usable + if (isset($current[$view]['context']) && is_array($current[$view]['context'])) { + //Merge with global context + $this->config[$tag][$view]['context'] = array_replace_recursive($this->config['context'], $this->config[$tag][$view]['context']); + + //Process every routes + foreach($current['route'] as $route => $key) { + //With confirm route + if ($route == 'confirm') { + //Skip route as it requires some parameters + continue; + } + + //Set value + $value = $router->generate( + $this->config['route'][$route]['name'], + $this->config['route'][$route]['context'], + //Generate absolute url for mails + $view=='mail'?UrlGeneratorInterface::ABSOLUTE_URL:UrlGeneratorInterface::ABSOLUTE_PATH + ); + + //Multi level key + if (strpos($key, '.') !== false) { + //Set tmp + $tmp = $value; + + //Iterate on key + foreach(array_reverse(explode('.', $key)) as $curkey) { + $tmp = array_combine([$curkey], [$tmp]); + } + + //Set value + $this->config[$tag][$view]['context'] = array_replace_recursive($this->config[$tag][$view]['context'], $tmp); + //Single level key + } else { + //Set value + $this->config[$tag][$view]['context'][$key] = $value; + } + } + + //Look for successful intersections + if (!empty(array_intersect_key($translates, $this->config[$tag][$view]['context']))) { + //Iterate on keys to translate + foreach($this->config['translate'] as $translate) { + //Set keys + $keys = explode('.', $translate); + + //Set tmp + $tmp = $this->config[$tag][$view]['context']; + + //Iterate on keys + foreach($keys as $curkey) { + //Without child key + if (!isset($tmp[$curkey])) { + //Skip to next key + continue(2); + } + + //Get child key + $tmp = $tmp[$curkey]; + } + + //Translate tmp value + $tmp = $translator->trans($tmp); + + //Iterate on keys + foreach(array_reverse($keys) as $curkey) { + //Set parent key + $tmp = array_combine([$curkey], [$tmp]); + } + + //Set value + $this->config[$tag][$view]['context'] = array_replace_recursive($this->config[$tag][$view]['context'], $tmp); + } + } + + //With view context + if ($view == 'view') { + //Get context path + $pathInfo = $router->getContext()->getPathInfo(); + + //Iterate on locales excluding current one + foreach($this->config['locales'] as $locale) { + //Set titles + $titles = []; + + //Iterate on other locales + foreach(array_diff($this->config['locales'], [$locale]) as $other) { + $titles[$other] = $translator->trans($this->config['languages'][$locale], [], null, $other); + } + + //Retrieve route matching path + $route = $router->match($pathInfo); + + //Get route name + $name = $route['_route']; + + //Unset route name + unset($route['_route']); + + //With current locale + if ($locale == $currentLocale) { + //Set locale locales context + $this->config[$tag][$view]['context']['canonical'] = $router->generate($name, ['_locale' => $locale]+$route, UrlGeneratorInterface::ABSOLUTE_URL); + } else { + //Set locale locales context + $this->config[$tag][$view]['context']['alternates'][$locale] = [ + 'absolute' => $router->generate($name, ['_locale' => $locale]+$route, UrlGeneratorInterface::ABSOLUTE_URL), + 'relative' => $router->generate($name, ['_locale' => $locale]+$route), + 'title' => implode('/', $titles), + 'translated' => $translator->trans($this->config['languages'][$locale], [], null, $locale) + ]; + } + + //Add shorter locale + if (empty($this->config[$tag][$view]['context']['alternates'][$slocale = substr($locale, 0, 2)])) { + //Add shorter locale + $this->config[$tag][$view]['context']['alternates'][$slocale] = [ + 'absolute' => $router->generate($name, ['_locale' => $locale]+$route, UrlGeneratorInterface::ABSOLUTE_URL), + 'relative' => $router->generate($name, ['_locale' => $locale]+$route), + 'title' => implode('/', $titles), + 'translated' => $translator->trans($this->config['languages'][$locale], [], null, $locale) + ]; + } + } + } + } + } + } } + } - //Render view - return $this->render($template, $context+array('form' => $form->createView(), 'error' => $error)); + /** + * Confirm account from mail link + * + * @param Request $request The request + * @param Registry $manager The doctrine registry + * @param UserPasswordEncoderInterface $encoder The password encoder + * @param EntityManagerInterface $manager The doctrine entity manager + * @param SluggerUtil $slugger The slugger + * @param MailerInterface $mailer The mailer + * @param string $mail The shorted mail address + * @param string $hash The hashed password + * @return Response The response + */ + public function confirm(Request $request, Registry $doctrine, UserPasswordEncoderInterface $encoder, EntityManagerInterface $manager, SluggerUtil $slugger, MailerInterface $mailer, $mail, $hash) { + //With invalid hash + if ($hash != $slugger->hash($mail)) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'hash', '%value%' => $hash])); + } + + //Get mail + $mail = $slugger->unshort($smail = $mail); + + //Without valid mail + if (filter_var($mail, FILTER_VALIDATE_EMAIL) === false) { + //Throw bad request + //XXX: prevent slugger reverse engineering by not displaying decoded mail + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'mail', '%value%' => $smail])); + } + + //Without existing registrant + if (!($user = $doctrine->getRepository($this->config['class']['user'])->findOneByMail($mail))) { + //Add error message mail already exists + //XXX: prevent slugger reverse engineering by not displaying decoded mail + $this->addFlash('error', $this->translator->trans('Account %mail% do not exists', ['%mail%' => $smail])); + + //Redirect to register view + return $this->redirectToRoute($this->config['route']['register']['name'], ['mail' => $smail, 'field' => $sfield = $slugger->serialize([]), 'hash' => $slugger->hash($smail.$sfield)]+$this->config['route']['register']['context']); + } + + //Set active + $user->setActive(true); + + //Set updated + $user->setUpdated(new \DateTime('now')); + + //Persist user + $manager->persist($user); + + //Send to database + $manager->flush(); + + //Add error message mail already exists + $this->addFlash('notice', $this->translator->trans('Your account has been activated')); + + //Redirect to user view + return $this->redirectToRoute($this->config['route']['edit']['name'], ['mail' => $smail, 'hash' => $slugger->hash($smail)]+$this->config['route']['edit']['context']); } - public function registerAction(Request $request, UserPasswordEncoderInterface $encoder) { - //Get mail template - $mailTemplate = $this->container->getParameter(($alias = $this->getAlias()).'.register.mail_template'); - //Get mail context - $mailContext = $this->container->getParameter($alias.'.register.mail_context'); - //Get template - $template = $this->container->getParameter($alias.'.register.template'); - //Get context - $context = $this->container->getParameter($alias.'.register.context'); - //Get home name - $homeName = $this->container->getParameter($alias.'.contact.home_name'); - //Get home args - $homeArgs = $this->container->getParameter($alias.'.contact.home_args'); - //Get contact name - $contactName = $this->container->getParameter($alias.'.contact.name'); - //Get contact mail - $contactMail = $this->container->getParameter($alias.'.contact.mail'); - //TODO: check if doctrine orm replacement is enough with default classes here - //Get class user - $classUser = $this->container->getParameter($alias.'.class.user'); - //Get class group - $classGroup = $this->container->getParameter($alias.'.class.group'); - //Get class title - $classTitle = $this->container->getParameter($alias.'.class.title'); - - //Create the form according to the FormType created previously. - //And give the proper parameters - $form = $this->createForm('Rapsys\UserBundle\Form\RegisterType', null, array( - // To set the action use $this->generateUrl('route_identifier') - 'class_title' => $classTitle, - 'action' => $this->generateUrl('rapsys_user_register'), + /** + * Edit account by shorted mail + * + * @param Request $request The request + * @param Registry $manager The doctrine registry + * @param EntityManagerInterface $manager The doctrine entity manager + * @param SluggerUtil $slugger The slugger + * @param string $mail The shorted mail address + * @param string $hash The hashed password + * @return Response The response + */ + public function edit(Request $request, Registry $doctrine, EntityManagerInterface $manager, SluggerUtil $slugger, $mail, $hash) { + //With invalid hash + if ($hash != $slugger->hash($mail)) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'hash', '%value%' => $hash])); + } + + //Get mail + $mail = $slugger->unshort($smail = $mail); + + //With existing subscriber + if (empty($user = $doctrine->getRepository($this->config['class']['user'])->findOneByMail($mail))) { + //Throw not found + //XXX: prevent slugger reverse engineering by not displaying decoded mail + throw $this->createNotFoundException($this->translator->trans('Unable to find account %mail%', ['%mail%' => $smail])); + } + + //Prevent access when not admin, user is not guest and not currently logged user + if (!$this->isGranted('ROLE_ADMIN') && $user != $this->getUser()) { + //Throw access denied + //XXX: prevent slugger reverse engineering by not displaying decoded mail + throw $this->createAccessDeniedException($this->translator->trans('Unable to access user: %mail%', ['%mail%' => $smail])); + } + + //Create the RegisterType form and give the proper parameters + $form = $this->createForm($this->config['register']['view']['form'], $user, [ + //Set action to register route name and context + 'action' => $this->generateUrl($this->config['route']['edit']['name'], ['mail' => $smail, 'hash' => $slugger->hash($smail)]+$this->config['route']['edit']['context']), + //Set civility class + 'civility_class' => $this->config['class']['civility'], + //Set civility default + 'civility_default' => $doctrine->getRepository($this->config['class']['civility'])->findOneByTitle($this->config['default']['civility']), + //Disable mail + 'mail' => $this->isGranted('ROLE_ADMIN'), + //Disable password + //XXX: prefer a reset on login to force user unspam action + 'password' => false, + //Set method 'method' => 'POST' - )); + ]); if ($request->isMethod('POST')) { - // Refill the fields in case the form is not valid. + //Refill the fields in case the form is not valid. $form->handleRequest($request); if ($form->isValid()) { - //Get translator - $trans = $this->get('translator'); - //Set data $data = $form->getData(); - //Translate title - $mailContext['title'] = $trans->trans($mailContext['title']); + //Queue snippet save + $manager->persist($data); - //Translate title - $mailContext['subtitle'] = $trans->trans($mailContext['subtitle'], array('%name%' => $data['forename'].' '.$data['surname'].' ('.$data['pseudonym'].')')); + //Flush to get the ids + $manager->flush(); - //Translate subject - $mailContext['subject'] = $trans->trans($mailContext['subject'], array('%title%' => $mailContext['title'])); + //Add notice + $this->addFlash('notice', $this->translator->trans('Account %mail% updated', ['%mail%' => $mail = $data->getMail()])); - //Translate message - $mailContext['message'] = $trans->trans($mailContext['message'], array('%title%' => $mailContext['title'])); + //Redirect to user view + //TODO: extract referer ??? or useless ??? + return $this->redirectToRoute($this->config['route']['edit']['name'], ['mail' => $smail = $slugger->short($mail), 'hash' => $slugger->hash($smail)]+$this->config['route']['edit']['context']); - //Create message - $message = \Swift_Message::newInstance() - ->setSubject($mailContext['subject']) - ->setFrom(array($contactMail => $contactName)) - ->setTo(array($data['mail'] => $data['forename'].' '.$data['surname'])) - ->setBody($mailContext['message']) - ->addPart( - $this->renderView( - $mailTemplate, - $mailContext+array( - 'home' => $this->get('router')->generate($homeName, $homeArgs, UrlGeneratorInterface::ABSOLUTE_URL) - ) - ), - 'text/html' - ); + //Redirect to cleanup the form + return $this->redirectToRoute('rapsys_air', ['user' => $data->getId()]); + } + } else { + //Add notice + $this->addFlash('notice', $this->translator->trans('To change your password relogin with your mail %mail% and any password then follow the procedure', ['%mail%' => $mail])); + } - //Get doctrine - $doctrine = $this->getDoctrine(); + //Render view + return $this->render( + //Template + $this->config['edit']['view']['name'], + //Context + ['form' => $form->createView(), 'sent' => $request->query->get('sent', 0)]+$this->config['edit']['view']['context'] + ); + } - //Get manager - $manager = $doctrine->getManager(); + /** + * Login + * + * @todo When account is not activated, refuse login and send verification mail ? + * @todo Redirect to referer if route is not connect ? + * + * @param Request $request The request + * @param AuthenticationUtils $authenticationUtils The authentication utils + * @param RouterInterface $router The router instance + * @param SluggerUtil $slugger The slugger + * @param string $mail The shorted mail address + * @param string $hash The hashed password + * @return Response The response + */ + public function login(Request $request, AuthenticationUtils $authenticationUtils, RouterInterface $router, SluggerUtil $slugger, $mail, $hash) { + //Create the LoginType form and give the proper parameters + $login = $this->createForm($this->config['login']['view']['form'], null, [ + //Set action to login route name and context + 'action' => $this->generateUrl($this->config['route']['login']['name'], $this->config['route']['login']['context']), + //Disable repeated password + 'password_repeated' => false, + //Set method + 'method' => 'POST' + ]); - //Init reflection - $reflection = new \ReflectionClass($classUser); + //Init context + $context = []; - //Create new user - $user = $reflection->newInstance(); + //With mail + if (!empty($mail) && !empty($hash)) { + //With invalid hash + if ($hash != $slugger->hash($mail)) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'hash', '%value%' => $hash])); + } - $user->setMail($data['mail']); - $user->setPseudonym($data['pseudonym']); - $user->setForename($data['forename']); - $user->setSurname($data['surname']); - $user->setPassword($encoder->encodePassword($user, $data['password'])); - $user->setActive(true); - $user->setTitle($data['title']); - //TODO: see if we can't modify group constructor to set role directly from args - //XXX: see vendor/symfony/symfony/src/Symfony/Component/Security/Core/Role/Role.php - $user->addGroup($doctrine->getRepository($classGroup)->findOneByRole('ROLE_USER')); - $user->setCreated(new \DateTime('now')); - $user->setUpdated(new \DateTime('now')); + //Get mail + $mail = $slugger->unshort($smail = $mail); - //Persist user - $manager->persist($user); + //Without valid mail + if (filter_var($mail, FILTER_VALIDATE_EMAIL) === false) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'mail', '%value%' => $smail])); + } - try { - //Send to database - $manager->flush(); + //Prefilled mail + $login->get('mail')->setData($mail); + //Last username entered by the user + } elseif ($lastUsername = $authenticationUtils->getLastUsername()) { + $login->get('mail')->setData($lastUsername); + } + + //Get the login error if there is one + if ($error = $authenticationUtils->getLastAuthenticationError()) { + //Get translated error + $error = $this->translator->trans($error->getMessageKey()); + + //Add error message to mail field + $login->get('mail')->addError(new FormError($error)); + + //Create the LoginType form and give the proper parameters + $recover = $this->createForm($this->config['recover']['view']['form'], null, [ + //Set action to recover route name and context + 'action' => $this->generateUrl($this->config['route']['recover']['name'], $this->config['route']['recover']['context']), + //Without password + 'password' => false, + //Set method + 'method' => 'POST' + ]); + + //Get recover mail entity + $recover->get('mail') + //Set mail from login form + ->setData($login->get('mail')->getData()) + //Add recover error + ->addError(new FormError($this->translator->trans('Use this form to recover your account'))); + + //Add recover form to context + $context['recover'] = $recover->createView(); + } else { + //Add notice + //TODO: drop it if referer route is recover ? + $this->addFlash('notice', $this->translator->trans('To change your password login with your mail and any password then follow the procedure')); + } + + //Render view + return $this->render( + //Template + $this->config['login']['view']['name'], + //Context + ['login' => $login->createView()]+$context+$this->config['login']['view']['context'] + ); + } + + /** + * Recover account + * + * @param Request $request The request + * @param Registry $manager The doctrine registry + * @param UserPasswordEncoderInterface $encoder The password encoder + * @param EntityManagerInterface $manager The doctrine entity manager + * @param SluggerUtil $slugger The slugger + * @param MailerInterface $mailer The mailer + * @param string $mail The shorted mail address + * @param string $pass The shorted password + * @param string $hash The hashed password + * @return Response The response + */ + public function recover(Request $request, Registry $doctrine, UserPasswordEncoderInterface $encoder, EntityManagerInterface $manager, SluggerUtil $slugger, MailerInterface $mailer, $mail, $pass, $hash) { + //Without mail, pass and hash + if (empty($mail) && empty($pass) && empty($hash)) { + //Create the LoginType form and give the proper parameters + $form = $this->createForm($this->config['recover']['view']['form'], null, [ + //Set action to recover route name and context + 'action' => $this->generateUrl($this->config['route']['recover']['name'], $this->config['route']['recover']['context']), + //Without password + 'password' => false, + //Set method + 'method' => 'POST' + ]); - //Send message - if ($this->get('mailer')->send($message)) { - //Redirect to cleanup the form - return $this->redirectToRoute('rapsys_user_register', array('sent' => 1)); + if ($request->isMethod('POST')) { + //Refill the fields in case the form is not valid. + $form->handleRequest($request); + + if ($form->isValid()) { + //Set data + $data = $form->getData(); + + //Find user by data mail + if ($user = $doctrine->getRepository($this->config['class']['user'])->findOneByMail($data['mail'])) { + //Set mail shortcut + $recoverMail =& $this->config['recover']['mail']; + + //Set mail + $mail = $slugger->short($user->getMail()); + + //Set pass + $pass = $slugger->hash($user->getPassword()); + + //Generate each route route + foreach($this->config['recover']['route'] as $route => $tag) { + //Only process defined routes + if (!empty($this->config['route'][$route])) { + //Process for recover mail url + if ($route == 'recover') { + //Set the url in context + $recoverMail['context'][$tag] = $this->get('router')->generate( + $this->config['route'][$route]['name'], + //Prepend recover context with tag + [ + 'mail' => $mail, + 'pass' => $pass, + 'hash' => $slugger->hash($mail.$pass) + ]+$this->config['route'][$route]['context'], + UrlGeneratorInterface::ABSOLUTE_URL + ); + } + } + } + + //Set recipient_name + $recoverMail['context']['recipient_mail'] = $user->getMail(); + + //Set recipient_name + $recoverMail['context']['recipient_name'] = trim($user->getForename().' '.$user->getSurname().($user->getPseudonym()?' ('.$user->getPseudonym().')':'')); + + //Init subject context + $subjectContext = $slugger->flatten(array_replace_recursive($this->config['recover']['view']['context'], $recoverMail['context']), null, '.', '%', '%'); + + //Translate subject + $recoverMail['subject'] = ucfirst($this->translator->trans($recoverMail['subject'], $subjectContext)); + + //Create message + $message = (new TemplatedEmail()) + //Set sender + ->from(new Address($this->config['contact']['mail'], $this->config['contact']['title'])) + //Set recipient + //XXX: remove the debug set in vendor/symfony/mime/Address.php +46 + ->to(new Address($recoverMail['context']['recipient_mail'], $recoverMail['context']['recipient_name'])) + //Set subject + ->subject($recoverMail['subject']) + + //Set path to twig templates + ->htmlTemplate($recoverMail['html']) + ->textTemplate($recoverMail['text']) + + //Set context + //XXX: require recursive merge to avoid loosing subkeys + //['subject' => $recoverMail['subject']]+$recoverMail['context']+$this->config['recover']['view']['context'] + ->context(array_replace_recursive($this->config['recover']['view']['context'], $recoverMail['context'], ['subject' => $recoverMail['subject']])); + + //Try sending message + //XXX: mail delivery may silently fail + try { + //Send message + $mailer->send($message); + + //Redirect on the same route with sent=1 to cleanup form + return $this->redirectToRoute($request->get('_route'), ['sent' => 1]+$request->get('_route_params')); + //Catch obvious transport exception + } catch(TransportExceptionInterface $e) { + //Add error message mail unreachable + $form->get('mail')->addError(new FormError($this->translator->trans('Account found but unable to contact: %mail%', array('%mail%' => $data['mail'])))); + } + //Accout not found + } else { + //Add error message to mail field + $form->get('mail')->addError(new FormError($this->translator->trans('Unable to find account %mail%', ['%mail%' => $data['mail']]))); } - } catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) { - //Add error message mail already exists - $form->get('mail')->addError(new FormError($trans->trans('Account already exists: %mail%', array('%mail%' => $data['mail'])))); } } + + //Render view + return $this->render( + //Template + $this->config['recover']['view']['name'], + //Context + ['form' => $form->createView(), 'sent' => $request->query->get('sent', 0)]+$this->config['recover']['view']['context'] + ); } - //Render view - return $this->render($template, $context+array('form' => $form->createView(), 'sent' => $request->query->get('sent', 0))); - } + //With invalid hash + if ($hash != $slugger->hash($mail.$pass)) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'hash', '%value%' => $hash])); + } + + //Get mail + $mail = $slugger->unshort($smail = $mail); - public function recoverAction(Request $request, Slugger $slugger) { - //Get mail template - $mailTemplate = $this->container->getParameter(($alias = $this->getAlias()).'.recover.mail_template'); - //Get mail context - $mailContext = $this->container->getParameter($alias.'.recover.mail_context'); - //Get template - $template = $this->container->getParameter($alias.'.recover.template'); - //Get context - $context = $this->container->getParameter($alias.'.recover.context'); - //Get url name - $urlName = $this->container->getParameter($alias.'.recover.url_name'); - //Get url args - $urlArgs = $this->container->getParameter($alias.'.recover.url_args'); - //Get home name - $homeName = $this->container->getParameter($alias.'.contact.home_name'); - //Get home args - $homeArgs = $this->container->getParameter($alias.'.contact.home_args'); - //Get contact name - $contactName = $this->container->getParameter($alias.'.contact.name'); - //Get contact mail - $contactMail = $this->container->getParameter($alias.'.contact.mail'); - //Get class user - $classUser = $this->container->getParameter($alias.'.class.user'); - - //Create the form according to the FormType created previously. - //And give the proper parameters - $form = $this->createForm('Rapsys\UserBundle\Form\RecoverType', null, array( - // To set the action use $this->generateUrl('route_identifier') - 'action' => $this->generateUrl('rapsys_user_recover'), + //Without valid mail + if (filter_var($mail, FILTER_VALIDATE_EMAIL) === false) { + //Throw bad request + //XXX: prevent slugger reverse engineering by not displaying decoded mail + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'mail', '%value%' => $smail])); + } + + //With existing subscriber + if (empty($user = $doctrine->getRepository($this->config['class']['user'])->findOneByMail($mail))) { + //Throw not found + //XXX: prevent slugger reverse engineering by not displaying decoded mail + throw $this->createNotFoundException($this->translator->trans('Unable to find account %mail%', ['%mail%' => $smail])); + } + + //With unmatched pass + if ($pass != $slugger->hash($user->getPassword())) { + //Throw not found + //XXX: prevent use of outdated recover link + throw $this->createNotFoundException($this->translator->trans('Outdated recover link')); + } + + //Create the LoginType form and give the proper parameters + $form = $this->createForm($this->config['recover']['view']['form'], $user, [ + //Set action to recover route name and context + 'action' => $this->generateUrl($this->config['route']['recover']['name'], ['mail' => $smail, 'pass' => $pass, 'hash' => $hash]+$this->config['route']['recover']['context']), + //Without mail + 'mail' => false, + //Set method 'method' => 'POST' - )); + ]); if ($request->isMethod('POST')) { - // Refill the fields in case the form is not valid. + //Refill the fields in case the form is not valid. $form->handleRequest($request); if ($form->isValid()) { - //Get translator - $trans = $this->get('translator'); - - //Get doctrine - $doctrine = $this->getDoctrine(); - //Set data $data = $form->getData(); - //Translate title - $mailContext['title'] = $trans->trans($mailContext['title']); - - //Try to find user - if ($user = $doctrine->getRepository($classUser)->findOneByMail($data['mail'])) { - //Translate title - $mailContext['subtitle'] = $trans->trans($mailContext['subtitle'], array('%name%' => $user->getForename().' '.$user->getSurname().' ('.$user->getPseudonym().')')); - - //Translate subject - $mailContext['subject'] = $trans->trans($mailContext['subject'], array('%title%' => $mailContext['title'])); - - //Translate message - $mailContext['raw'] = $trans->trans($mailContext['raw'], array('%title%' => $mailContext['title'], '%url%' => $this->get('router')->generate($urlName, $urlArgs+array('mail' => $slugger->short($user->getMail()), 'hash' => $slugger->hash($user->getPassword())), UrlGeneratorInterface::ABSOLUTE_URL))); - - //Create message - $message = \Swift_Message::newInstance() - ->setSubject($mailContext['subject']) - ->setFrom(array($contactMail => $contactName)) - ->setTo(array($user->getMail() => $user->getForename().' '.$user->getSurname())) - ->setBody(strip_tags($mailContext['raw'])) - ->addPart( - $this->renderView( - $mailTemplate, - $mailContext+array( - 'home' => $this->get('router')->generate($homeName, $homeArgs, UrlGeneratorInterface::ABSOLUTE_URL) - ) - ), - 'text/html' - ); - - //Send message - if ($this->get('mailer')->send($message)) { - //Redirect to cleanup the form - return $this->redirectToRoute('rapsys_user_recover', array('sent' => 1)); - } - //Accout not found - } else { - //Add error message to mail field - $form->get('mail')->addError(new FormError($trans->trans('Unable to find account: %mail%', array('%mail%' => $data['mail'])))); - } + //Set encoded password + $encoded = $encoder->encodePassword($user, $user->getPassword()); + + //Update pass + $pass = $slugger->hash($encoded); + + //Set user password + $user->setPassword($encoded); + + //Set updated + $user->setUpdated(new \DateTime('now')); + + //Persist user + $manager->persist($user); + + //Send to database + $manager->flush(); + + //Add notice + $this->addFlash('notice', $this->translator->trans('Account %mail% password updated', ['%mail%' => $mail])); + + //Redirect to user login + return $this->redirectToRoute($this->config['route']['login']['name'], ['mail' => $smail, 'hash' => $slugger->hash($smail)]+$this->config['route']['login']['context']); } } //Render view - return $this->render($template, $context+array('form' => $form->createView(), 'sent' => $request->query->get('sent', 0))); + return $this->render( + //Template + $this->config['recover']['view']['name'], + //Context + ['form' => $form->createView(), 'sent' => $request->query->get('sent', 0)]+$this->config['recover']['view']['context'] + ); } - public function recoverMailAction(Request $request, UserPasswordEncoderInterface $encoder, Slugger $slugger, $mail, $hash) { - //Get mail template - $mailTemplate = $this->container->getParameter(($alias = $this->getAlias()).'.recover_mail.mail_template'); - //Get mail context - $mailContext = $this->container->getParameter($alias.'.recover_mail.mail_context'); - //Get template - $template = $this->container->getParameter($alias.'.recover_mail.template'); - //Get context - $context = $this->container->getParameter($alias.'.recover_mail.context'); - //Get url name - $urlName = $this->container->getParameter($alias.'.recover_mail.url_name'); - //Get url args - $urlArgs = $this->container->getParameter($alias.'.recover_mail.url_args'); - //Get home name - $homeName = $this->container->getParameter($alias.'.contact.home_name'); - //Get home args - $homeArgs = $this->container->getParameter($alias.'.contact.home_args'); - //Get contact name - $contactName = $this->container->getParameter($alias.'.contact.name'); - //Get contact mail - $contactMail = $this->container->getParameter($alias.'.contact.mail'); - //Get class user - $classUser = $this->container->getParameter($alias.'.class.user'); - - //Create the form according to the FormType created previously. - //And give the proper parameters - $form = $this->createForm('Rapsys\UserBundle\Form\RecoverMailType', null, array( - // To set the action use $this->generateUrl('route_identifier') - 'action' => $this->generateUrl('rapsys_user_recover_mail', array('mail' => $mail, 'hash' => $hash)), + /** + * Register an account + * + * @param Request $request The request + * @param Registry $manager The doctrine registry + * @param UserPasswordEncoderInterface $encoder The password encoder + * @param EntityManagerInterface $manager The doctrine entity manager + * @param SluggerUtil $slugger The slugger + * @param MailerInterface $mailer The mailer + * @param LoggerInterface $logger The logger + * @param string $mail The shorted mail address + * @param string $field The serialized then shorted form field array + * @param string $hash The hashed serialized field array + * @return Response The response + */ + public function register(Request $request, Registry $doctrine, UserPasswordEncoderInterface $encoder, EntityManagerInterface $manager, SluggerUtil $slugger, MailerInterface $mailer, LoggerInterface $logger, $mail, $field, $hash) { + //Init reflection + $reflection = new \ReflectionClass($this->config['class']['user']); + + //Create new user + $user = $reflection->newInstance(); + + //With mail and field + if (!empty($field) && !empty($hash)) { + //With invalid hash + if ($hash != $slugger->hash($mail.$field)) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'hash', '%value%' => $hash])); + } + + //With mail + if (!empty($mail)) { + //Get mail + $mail = $slugger->unshort($smail = $mail); + + //Without valid mail + if (filter_var($mail, FILTER_VALIDATE_EMAIL) === false) { + //Throw bad request + //XXX: prevent slugger reverse engineering by not displaying decoded mail + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'mail', '%value%' => $smail])); + } + + //Set mail + $user->setMail($mail); + //Without mail + } else { + //Set smail + $smail = $mail; + } + + //Try + try { + //Unshort then unserialize field + $field = $slugger->unserialize($sfield = $field); + //Catch type error + } catch (\Error|\Exception $e) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'field', '%value%' => $field]), $e); + } + + //With non array field + if (!is_array($field)) { + //Throw bad request + throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'field', '%value%' => $field])); + } + //Without field and hash + } else { + //Set smail + $smail = $mail; + + //Set smail + $sfield = $sfield; + + //Reset field + $field = []; + } + + //Create the RegisterType form and give the proper parameters + $form = $this->createForm($this->config['register']['view']['form'], $user, $field+[ + //Set action to register route name and context + 'action' => $this->generateUrl($this->config['route']['register']['name'], ['mail' => $smail, 'field' => $sfield, 'hash' => $hash]+$this->config['route']['register']['context']), + //Set civility class + 'civility_class' => $this->config['class']['civility'], + //Set civility default + 'civility_default' => $doctrine->getRepository($this->config['class']['civility'])->findOneByTitle($this->config['default']['civility']), + //With mail + 'mail' => true, + //Set method 'method' => 'POST' - )); + ]); - //Get doctrine - $doctrine = $this->getDoctrine(); + if ($request->isMethod('POST')) { + //Refill the fields in case the form is not valid. + $form->handleRequest($request); - //Get translator - $trans = $this->get('translator'); + if ($form->isValid()) { + //Set data + $data = $form->getData(); - //Init not found - $notfound = 1; + //With existing registrant + if ($doctrine->getRepository($this->config['class']['user'])->findOneByMail($mail = $data->getMail())) { + //Add error message mail already exists + $this->addFlash('warning', $this->translator->trans('Account %mail% already exists', ['%mail%' => $mail])); + + //Redirect to user view + return $this->redirectToRoute( + $this->config['route']['edit']['name'], + [ + 'mail' => $smail = $slugger->short($mail), + 'hash' => $slugger->hash($smail) + ]+$this->config['route']['edit']['context'] + ); + } - //Retrieve user - if (($user = $doctrine->getRepository($classUser)->findOneByMail($slugger->unshort($mail))) && $hash == $slugger->hash($user->getPassword())) { - //User was found - $notfound = 0; + //Set mail shortcut + $registerMail =& $this->config['register']['mail']; - if ($request->isMethod('POST')) { - // Refill the fields in case the form is not valid. - $form->handleRequest($request); + //Extract names and pseudonym from mail + $names = explode(' ', $pseudonym = ucwords(trim(preg_replace('/[^a-zA-Z]+/', ' ', current(explode('@', $data->getMail())))))); - if ($form->isValid()) { - //Set data - $data = $form->getData(); + //Set pseudonym + $user->setPseudonym($user->getPseudonym()??$pseudonym); + + //Set forename + $user->setForename($user->getForename()??$names[0]); - //Translate title - $mailContext['title'] = $trans->trans($mailContext['title']); + //Set surname + $user->setSurname($user->getSurname()??$names[1]??$names[0]); - //Translate title - $mailContext['subtitle'] = $trans->trans($mailContext['subtitle'], array('%name%' => $user->getForename().' '.$user->getSurname().' ('.$user->getPseudonym().')')); + //Set password + $user->setPassword($encoder->encodePassword($user, $user->getPassword()??$data->getMail())); - //Translate subject - $mailContext['subject'] = $trans->trans($mailContext['subject'], array('%title%' => $mailContext['title'])); + //Set created + $user->setCreated(new \DateTime('now')); + + //Set updated + $user->setUpdated(new \DateTime('now')); + + //Persist user + $manager->persist($user); - //Set user password - $user->setPassword($encoder->encodePassword($user, $data['password'])); + //Iterate on default group + foreach($this->config['default']['group'] as $i => $groupTitle) { + //Fetch group + if (($group = $doctrine->getRepository($this->config['class']['group'])->findOneByTitle($groupTitle))) { + //Set default group + //XXX: see vendor/symfony/security-core/Role/Role.php + $user->addGroup($group); + //Group not found + } else { + //Throw exception + //XXX: consider missing group as fatal + throw new \Exception(sprintf('Group from rapsys_user.default.group[%d] not found by title: %s', $i, $groupTitle)); + } + } + + //Generate each route route + foreach($this->config['register']['route'] as $route => $tag) { + //Only process defined routes + if (!empty($this->config['route'][$route])) { + //Process for confirm url + if ($route == 'confirm') { + //Set the url in context + $registerMail['context'][$tag] = $this->get('router')->generate( + $this->config['route'][$route]['name'], + //Prepend subscribe context with tag + [ + 'mail' => $smail = $slugger->short($data->getMail()), + 'hash' => $slugger->hash($smail) + ]+$this->config['route'][$route]['context'], + UrlGeneratorInterface::ABSOLUTE_URL + ); + } + } + } - //Translate message - $mailContext['raw'] = $trans->trans($mailContext['raw'], array('%title%' => $mailContext['title'], '%url%' => $this->get('router')->generate($urlName, $urlArgs+array('mail' => $slugger->short($user->getMail()), 'hash' => $slugger->hash($user->getPassword())), UrlGeneratorInterface::ABSOLUTE_URL))); + //XXX: DEBUG: remove me + //die($registerMail['context']['confirm_url']); - //Get manager - $manager = $doctrine->getManager(); + //Log new user infos + //XXX: useless ??? + $logger->emergency( + $this->translator->trans( + 'newuser:mail=%mail%|locale=%locale%|confirm=%confirm%', + [ + '%mail%' => $data->getMail(), + '%locale%' => $request->getLocale(), + '%confirm%' => $registerMail['context'][$this->config['register']['route']['confirm']] + ] + ) + ); - //Persist user - $manager->persist($user); + //Set recipient_name + $registerMail['context']['recipient_mail'] = $data->getMail(); + //Set recipient name + $registerMail['context']['recipient_name'] = ''; + + //Set recipient name + $registerMail['context']['recipient_name'] = implode(' ', [$data->getForename(), $data->getSurname(), $data->getPseudonym()?'('.$data->getPseudonym().')':'']); + + //Init subject context + $subjectContext = $slugger->flatten(array_replace_recursive($this->config['register']['view']['context'], $registerMail['context']), null, '.', '%', '%'); + + //Translate subject + $registerMail['subject'] = ucfirst($this->translator->trans($registerMail['subject'], $subjectContext)); + + //Create message + $message = (new TemplatedEmail()) + //Set sender + ->from(new Address($this->config['contact']['mail'], $this->config['contact']['title'])) + //Set recipient + //XXX: remove the debug set in vendor/symfony/mime/Address.php +46 + ->to(new Address($registerMail['context']['recipient_mail'], $registerMail['context']['recipient_name'])) + //Set subject + ->subject($registerMail['subject']) + + //Set path to twig templates + ->htmlTemplate($registerMail['html']) + ->textTemplate($registerMail['text']) + + //Set context + ->context(['subject' => $registerMail['subject']]+$registerMail['context']); + + //Try saving in database + try { //Send to database $manager->flush(); - //Create message - $message = \Swift_Message::newInstance() - ->setSubject($mailContext['subject']) - ->setFrom(array($contactMail => $contactName)) - ->setTo(array($user->getMail() => $user->getForename().' '.$user->getSurname())) - ->setBody(strip_tags($mailContext['raw'])) - ->addPart( - $this->renderView( - $mailTemplate, - $mailContext+array( - 'home' => $this->get('router')->generate($homeName, $homeArgs, UrlGeneratorInterface::ABSOLUTE_URL) - ) - ), - 'text/html' - ); - - //Send message - if ($this->get('mailer')->send($message)) { - //Redirect to cleanup the form - return $this->redirectToRoute('rapsys_user_recover_mail', array('mail' => $mail, 'hash' => $hash, 'sent' => 1)); + //Add error message mail already exists + $this->addFlash('notice', $this->translator->trans('Your account has been created')); + + //Try sending message + //XXX: mail delivery may silently fail + try { + //Send message + $mailer->send($message); + + //Redirect on the same route with sent=1 to cleanup form + return $this->redirectToRoute($request->get('_route'), ['sent' => 1]+$request->get('_route_params')); + //Catch obvious transport exception + } catch(TransportExceptionInterface $e) { + //Add error message mail unreachable + $form->get('mail')->addError(new FormError($this->translator->trans('Account %mail% tried subscribe but unable to contact', ['%mail%' => $data->getMail()]))); } + //Catch double subscription + } catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) { + //Add error message mail already exists + $this->addFlash('error', $this->translator->trans('Account %mail% already exists', ['%mail%' => $mail])); } } } //Render view - return $this->render($template, $context+array('form' => $form->createView(), 'sent' => $request->query->get('sent', 0), 'notfound' => $notfound)); + return $this->render( + //Template + $this->config['register']['view']['name'], + //Context + ['form' => $form->createView(), 'sent' => $request->query->get('sent', 0)]+$this->config['register']['view']['context'] + ); } /** * {@inheritdoc} */ - public function getAlias() { - return 'rapsys_user'; + public function getAlias(): string { + return RapsysUserBundle::getAlias(); } }