Replace dropped calls with checker, factory and security replacements

[airbundle] / Entity / Location.php

diff --git a/Entity/Location.php b/Entity/Location.php
index fd619698cbf4ff8b455f70f728bfec446bca5737..73b07f7c93d02183f9b6db768cab05c48ffea2b5 100644 (file)
--- a/Entity/Location.php
+++ b/Entity/Location.php
@@ -1,7 +1,19 @@
-<?php
+<?php declare(strict_types=1);
+
+/*
+ * this file is part of the rapsys packbundle package.
+ *
+ * (c) raphaël gertz <symfony@rapsys.eu>
+ *
+ * for the full copyright and license information, please view the license
+ * file that was distributed with this source code.
+ */

 
 namespace Rapsys\AirBundle\Entity;
 
 
 namespace Rapsys\AirBundle\Entity;
 

+use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\ORM\Event\PreUpdateEventArgs;
+

 /**
  * Location
  */
 /**
  * Location
  */


@@ -19,7 +31,7 @@ class Location {
        /**
         * @var string
         */
        /**
         * @var string
         */

-       private $short;
+       protected $description;

 
        /**
         * @var string
 
        /**
         * @var string


@@ -47,7 +59,12 @@ class Location {
        private $longitude;
 
        /**
        private $longitude;
 
        /**

-        * @var boolean
+        * @var bool
+        */
+       private $indoor;
+
+       /**
+        * @var bool

         */
        private $hotspot;
 
         */
        private $hotspot;
 


@@ -62,17 +79,17 @@ class Location {
        private $updated;
 
        /**
        private $updated;
 
        /**

-        * @var \Doctrine\Common\Collections\Collection
+        * @var ArrayCollection

         */
        private $sessions;
 
        /**
         */
        private $sessions;
 
        /**

-        * @var \Doctrine\Common\Collections\Collection
+        * @var ArrayCollection

         */
        private $snippets;
 
        /**
         */
        private $snippets;
 
        /**

-        * @var \Doctrine\Common\Collections\Collection
+        * @var ArrayCollection

         */
        private $users;
 
         */
        private $users;
 


@@ -80,9 +97,13 @@ class Location {
         * Constructor
         */
        public function __construct() {
         * Constructor
         */
        public function __construct() {

-               $this->sessions = new \Doctrine\Common\Collections\ArrayCollection();
-               $this->snippets = new \Doctrine\Common\Collections\ArrayCollection();
-               $this->users = new \Doctrine\Common\Collections\ArrayCollection();
+               //Set defaults
+               $this->description = null;
+               $this->created = new \DateTime('now');
+               $this->updated = new \DateTime('now');
+               $this->sessions = new ArrayCollection();
+               $this->snippets = new ArrayCollection();
+               $this->users = new ArrayCollection();

        }
 
        /**
        }
 
        /**


@@ -90,7 +111,7 @@ class Location {
         *
         * @return integer
         */
         *
         * @return integer
         */

-       public function getId() {
+       public function getId(): int {

                return $this->id;
        }
 
                return $this->id;
        }
 


@@ -101,7 +122,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setTitle($title) {
+       public function setTitle(string $title): Location {

                $this->title = $title;
 
                return $this;
                $this->title = $title;
 
                return $this;


@@ -112,30 +133,30 @@ class Location {
         *
         * @return string
         */
         *
         * @return string
         */

-       public function getTitle() {
+       public function getTitle(): string {

                return $this->title;
        }
 
        /**
                return $this->title;
        }
 
        /**

-        * Set short
+        * Set description

         *
         *

-        * @param string $short
+        * @param string $description

         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setShort($short) {
-               $this->short = $short;
+       public function setDescription(?string $description): Location {
+               $this->description = $description;

 
                return $this;
        }
 
        /**
 
                return $this;
        }
 
        /**

-        * Get short
+        * Get description

         *
         * @return string
         */
         *
         * @return string
         */

-       public function getShort() {
-               return $this->short;
+       public function getDescription(): ?string {
+               return $this->description;

        }
 
        /**
        }
 
        /**


@@ -145,7 +166,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setAddress($address) {
+       public function setAddress(string $address): Location {

                $this->address = $address;
 
                return $this;
                $this->address = $address;
 
                return $this;


@@ -156,7 +177,7 @@ class Location {
         *
         * @return string
         */
         *
         * @return string
         */

-       public function getAddress() {
+       public function getAddress(): string {

                return $this->address;
        }
 
                return $this->address;
        }
 


@@ -167,7 +188,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setZipcode($zipcode) {
+       public function setZipcode(string $zipcode): Location {

                $this->zipcode = $zipcode;
 
                return $this;
                $this->zipcode = $zipcode;
 
                return $this;


@@ -178,7 +199,7 @@ class Location {
         *
         * @return string
         */
         *
         * @return string
         */

-       public function getZipcode() {
+       public function getZipcode(): string {

                return $this->zipcode;
        }
 
                return $this->zipcode;
        }
 


@@ -189,7 +210,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setCity($city) {
+       public function setCity(string $city): Location {

                $this->city = $city;
 
                return $this;
                $this->city = $city;
 
                return $this;


@@ -200,7 +221,7 @@ class Location {
         *
         * @return string
         */
         *
         * @return string
         */

-       public function getCity() {
+       public function getCity(): string {

                return $this->city;
        }
 
                return $this->city;
        }
 


@@ -211,7 +232,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setLatitude($latitude) {
+       public function setLatitude(string $latitude): Location {

                $this->latitude = $latitude;
 
                return $this;
                $this->latitude = $latitude;
 
                return $this;


@@ -222,7 +243,7 @@ class Location {
         *
         * @return string
         */
         *
         * @return string
         */

-       public function getLatitude() {
+       public function getLatitude(): string {

                return $this->latitude;
        }
 
                return $this->latitude;
        }
 


@@ -233,7 +254,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setLongitude($longitude) {
+       public function setLongitude(string $longitude): Location {

                $this->longitude = $longitude;
 
                return $this;
                $this->longitude = $longitude;
 
                return $this;


@@ -244,18 +265,40 @@ class Location {
         *
         * @return string
         */
         *
         * @return string
         */

-       public function getLongitude() {
+       public function getLongitude(): string {

                return $this->longitude;
        }
 
                return $this->longitude;
        }
 

+       /**
+        * Set indoor
+        *
+        * @param bool $indoor
+        *
+        * @return Session
+        */
+       public function setIndoor(bool $indoor): Location {
+               $this->indoor = $indoor;
+
+               return $this;
+       }
+
+       /**
+        * Get indoor
+        *
+        * @return bool
+        */
+       public function getIndoor(): bool {
+               return $this->indoor;
+       }
+

        /**
         * Set hotspot
         *
        /**
         * Set hotspot
         *

-        * @param boolean $hotspot
+        * @param bool $hotspot

         *
         * @return Session
         */
         *
         * @return Session
         */

-       public function setHotspot($hotspot) {
+       public function setHotspot(bool $hotspot): Location {

                $this->hotspot = $hotspot;
 
                return $this;
                $this->hotspot = $hotspot;
 
                return $this;


@@ -264,9 +307,9 @@ class Location {
        /**
         * Get hotspot
         *
        /**
         * Get hotspot
         *

-        * @return boolean
+        * @return bool

         */
         */

-       public function getHotspot() {
+       public function getHotspot(): bool {

                return $this->hotspot;
        }
 
                return $this->hotspot;
        }
 


@@ -277,7 +320,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setCreated($created) {
+       public function setCreated(\DateTime $created): Location {

                $this->created = $created;
 
                return $this;
                $this->created = $created;
 
                return $this;


@@ -288,7 +331,7 @@ class Location {
         *
         * @return \DateTime
         */
         *
         * @return \DateTime
         */

-       public function getCreated() {
+       public function getCreated(): \DateTime {

                return $this->created;
        }
 
                return $this->created;
        }
 


@@ -299,7 +342,7 @@ class Location {
         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function setUpdated($updated) {
+       public function setUpdated(\DateTime $updated): Location {

                $this->updated = $updated;
 
                return $this;
                $this->updated = $updated;
 
                return $this;


@@ -310,18 +353,18 @@ class Location {
         *
         * @return \DateTime
         */
         *
         * @return \DateTime
         */

-       public function getUpdated() {
+       public function getUpdated(): \DateTime {

                return $this->updated;
        }
 
        /**
         * Add session
         *
                return $this->updated;
        }
 
        /**
         * Add session
         *

-        * @param \Rapsys\AirBundle\Entity\Session $session
+        * @param Session $session

         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function addSession(\Rapsys\AirBundle\Entity\Session $session) {
+       public function addSession(Session $session): Location {

                $this->sessions[] = $session;
 
                return $this;
                $this->sessions[] = $session;
 
                return $this;


@@ -330,29 +373,30 @@ class Location {
        /**
         * Remove session
         *
        /**
         * Remove session
         *

-        * @param \Rapsys\AirBundle\Entity\Session $session
+        * @param Session $session
+        * @return bool

         */
         */

-       public function removeSession(\Rapsys\AirBundle\Entity\Session $session) {
-               $this->sessions->removeElement($session);
+       public function removeSession(Session $session): bool {
+               return $this->sessions->removeElement($session);

        }
 
        /**
         * Get sessions
         *
        }
 
        /**
         * Get sessions
         *

-        * @return \Doctrine\Common\Collections\Collection
+        * @return ArrayCollection

         */
         */

-       public function getSessions() {
+       public function getSessions(): ArrayCollection {

                return $this->sessions;
        }
 
        /**
         * Add snippet
         *
                return $this->sessions;
        }
 
        /**
         * Add snippet
         *

-        * @param \Rapsys\AirBundle\Entity\Snippet $snippet
+        * @param Snippet $snippet

         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function addSnippet(\Rapsys\AirBundle\Entity\Snippet $snippet) {
+       public function addSnippet(Snippet $snippet): Location {

                $this->snippets[] = $snippet;
 
                return $this;
                $this->snippets[] = $snippet;
 
                return $this;


@@ -361,29 +405,33 @@ class Location {
        /**
         * Remove snippet
         *
        /**
         * Remove snippet
         *

-        * @param \Rapsys\AirBundle\Entity\Snippet $snippet
+        * @param Snippet $snippet
+        * @return bool

         */
         */

-       public function removeSnippet(\Rapsys\AirBundle\Entity\Snippet $snippet) {
-               $this->snippets->removeElement($snippet);
+       public function removeSnippet(Snippet $snippet): bool {
+               return $this->snippets->removeElement($snippet);

        }
 
        /**
         * Get snippets
         *
        }
 
        /**
         * Get snippets
         *

-        * @return \Doctrine\Common\Collections\Collection
+        * @return ArrayCollection

         */
         */

-       public function getSnippets() {
+       public function getSnippets(): ArrayCollection {

                return $this->snippets;
        }
 
        /**
         * Add user
         *
                return $this->snippets;
        }
 
        /**
         * Add user
         *

-        * @param \Rapsys\AirBundle\Entity\User $user
+        * @param User $user

         *
         * @return Location
         */
         *
         * @return Location
         */

-       public function addUser(\Rapsys\AirBundle\Entity\User $user) {
+       public function addUser(User $user): Location {
+               //Add from owning side
+               $user->addLocation($this);
+

                $this->users[] = $user;
 
                return $this;
                $this->users[] = $user;
 
                return $this;


@@ -392,21 +440,40 @@ class Location {
        /**
         * Remove user
         *
        /**
         * Remove user
         *

-        * @param \Rapsys\AirBundle\Entity\User $user
+        * @param User $user
+        * @return bool

         */
         */

-       public function removeUser(\Rapsys\AirBundle\Entity\User $user) {
-               $this->users->removeElement($user);
+       public function removeUser(User $user): bool {
+               if (!$this->locations->contains($user)) {
+                       return true;
+               }
+
+               //Remove from owning side
+               $user->removeLocation($this);
+
+               return $this->users->removeElement($user);

        }
 
        /**
         * Get users
         *
        }
 
        /**
         * Get users
         *

-        * @return \Doctrine\Common\Collections\Collection
+        * @return ArrayCollection

         */
         */

-       public function getUsers() {
+       public function getUsers(): ArrayCollection {

                return $this->users;
        }
 
                return $this->users;
        }
 

+       /**
+        * {@inheritdoc}
+        */
+       public function preUpdate(PreUpdateEventArgs $eventArgs) {
+               //Check that we have a location instance
+               if (($location = $eventArgs->getEntity()) instanceof Location) {
+                       //Set updated value
+                       $location->setUpdated(new \DateTime('now'));
+               }
+       }
+

        /**
         * Returns a string representation of the location
         *
        /**
         * Returns a string representation of the location
         *