Update to 4.x new path

[packbundle] / DependencyInjection / Configuration.php

diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
index 2e64eed62cb4b5b8678cb2e1a8293aac3ee69b94..bfa4b3cd424cb30af9051ded1b9035c98d51f9af 100644 (file)
--- a/DependencyInjection/Configuration.php
+++ b/DependencyInjection/Configuration.php
@@ -13,7 +13,7 @@ use Symfony\Component\Process\ExecutableFinder;
  */
 class Configuration implements ConfigurationInterface {
        //Constructor required to derivate prefix from kernel.project_dir
  */
 class Configuration implements ConfigurationInterface {
        //Constructor required to derivate prefix from kernel.project_dir

-       public function __construct(string $projectDir) {
+       public function __construct($projectDir) {

                $this->projectDir = $projectDir;
        }
 
                $this->projectDir = $projectDir;
        }
 


@@ -21,7 +21,10 @@ class Configuration implements ConfigurationInterface {
         * {@inheritdoc}
         */
        public function getConfigTreeBuilder() {
         * {@inheritdoc}
         */
        public function getConfigTreeBuilder() {

-               $treeBuilder = new TreeBuilder();
+               //Get TreeBuilder object
+               $treeBuilder = new TreeBuilder('parameters');
+
+               //Get ExecutableFinder object

                $finder = new ExecutableFinder();
 
                #TODO: see how we deal with asset url generation: see Rapsys/PackBundle/Twig/PackTokenParser.php +243
                $finder = new ExecutableFinder();
 
                #TODO: see how we deal with asset url generation: see Rapsys/PackBundle/Twig/PackTokenParser.php +243


@@ -36,50 +39,138 @@ class Configuration implements ConfigurationInterface {
                ##twig:
                ##    cache: ~
 
                ##twig:
                ##    cache: ~
 

-               //Here we define the parameters that are allowed to configure the bundle.

                //TODO: see https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php for default value and description
                //TODO: see http://symfony.com/doc/current/components/config/definition.html
                //TODO: see https://github.com/symfony/assetic-bundle/blob/master/DependencyInjection/Configuration.php#L63
                //TODO: use bin/console config:dump-reference to dump class infos
                //TODO: see https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php for default value and description
                //TODO: see http://symfony.com/doc/current/components/config/definition.html
                //TODO: see https://github.com/symfony/assetic-bundle/blob/master/DependencyInjection/Configuration.php#L63
                //TODO: use bin/console config:dump-reference to dump class infos

+
+               //The bundle default values
+               $defaults = [
+                       'config' => [
+                               'prefix' => $this->projectDir,
+                               'name' => 'asset_url',
+                               'scheme' => 'https://',
+                               'timeout' => (int)ini_get('default_socket_timeout'),
+                               'agent' => (string)ini_get('user_agent')?:'rapsys_pack/0.0.2',
+                               'redirect' => 5
+                       ],
+                       'output' => [
+                               'css' => 'css/*.pack.css',
+                               'js' => 'js/*.pack.js',
+                               'img' => 'img/*.pack.jpg'
+                       ],
+                       'filters' => [
+                               'css' => [
+                                       'class' => 'Rapsys\PackBundle\Twig\Filter\CPackFilter',
+                                       'args' => [
+                                               $finder->find('cpack', '/usr/local/bin/cpack'),
+                                               'minify'
+                                       ]
+                               ],
+                               'js' => [
+                                       'class' => 'Rapsys\PackBundle\Twig\Filter\JPackFilter',
+                                       'args' => [
+                                               $finder->find('jpack', '/usr/local/bin/jpack'),
+                                               'best'
+                                       ]
+                               ],
+                               'img' => [
+                                       'class' => 'Rapsys\PackBundle\Twig\Filter\IPackFilter',
+                                       'args' => []
+                               ],
+                       ]
+               ];
+
+               //Here we define the parameters that are allowed to configure the bundle.

                $treeBuilder
                        //Parameters
                $treeBuilder
                        //Parameters

-                       ->root('parameters')
+                       ->getRootNode()
+                               ->addDefaultsIfNotSet()

                                ->children()
                                        ->arrayNode('rapsys_pack')
                                ->children()
                                        ->arrayNode('rapsys_pack')

+                                               ->addDefaultsIfNotSet()

                                                ->children()
                                                ->children()

-                                                       ->scalarNode('coutput')->defaultValue('css/*.pack.css')->end()
-                                                       ->scalarNode('joutput')->defaultValue('js/*.pack.js')->end()
-                                                       ->scalarNode('ioutput')->defaultValue('img/*.pack.jpg')->end()
-                                                       ->arrayNode('cfilter')
-                                                               ->treatNullLike(array())
-                                                               ->scalarPrototype()->end()
-                                                               ->defaultValue(array('Rapsys\PackBundle\Twig\Filter\CPackFilter'))
+                                                       ->arrayNode('config')
+                                                               ->isRequired()
+                                                               ->addDefaultsIfNotSet()
+                                                               ->children()
+                                                                       ->scalarNode('prefix')->isRequired()->defaultValue($defaults['config']['prefix'])->end()
+                                                                       ->scalarNode('name')->isRequired()->defaultValue($defaults['config']['name'])->end()
+                                                                       ->scalarNode('scheme')->isRequired()->defaultValue($defaults['config']['scheme'])->end()
+                                                                       ->integerNode('timeout')->isRequired()->min(0)->defaultValue($defaults['config']['timeout'])->end()
+                                                                       ->scalarNode('agent')->isRequired()->defaultValue($defaults['config']['agent'])->end()
+                                                                       ->integerNode('redirect')->isRequired()->min(1)->defaultValue($defaults['config']['redirect'])->end()
+                                                               ->end()

                                                        ->end()
                                                        ->end()

-                                                       ->arrayNode('jfilter')
-                                                               ->treatNullLike(array())
-                                                               ->scalarPrototype()->end()
-                                                               ->defaultValue(array('Rapsys\PackBundle\Twig\Filter\JPackFilter'))
+                                                       ->arrayNode('output')
+                                                               ->isRequired()
+                                                               ->addDefaultsIfNotSet()
+                                                               ->children()
+                                                                       ->scalarNode('css')->isRequired()->defaultValue($defaults['output']['css'])->end()
+                                                                       ->scalarNode('js')->isRequired()->defaultValue($defaults['output']['js'])->end()
+                                                                       ->scalarNode('img')->isRequired()->defaultValue($defaults['output']['img'])->end()
+                                                               ->end()

                                                        ->end()
                                                        ->end()

-                                                       ->arrayNode('ifilter')
-                                                               ->treatNullLike(array())
-                                                               ->scalarPrototype()->end()
-                                                               ->defaultValue(array('Rapsys\PackBundle\Twig\Filter\IPackFilter'))
+                                                       ->arrayNode('filters')
+                                                               ->isRequired()
+                                                               ->addDefaultsIfNotSet()
+                                                               ->children()
+                                                                       ->arrayNode('css')
+                                                                               #XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+                                                                               ->addDefaultChildrenIfNoneSet()
+                                                                               ->arrayPrototype()
+                                                                                       ->children()
+                                                                                               ->scalarNode('class')
+                                                                                                       ->isRequired()
+                                                                                                       ->defaultValue($defaults['filters']['css']['class'])
+                                                                                               ->end()
+                                                                                               ->arrayNode('args')
+                                                                                                       ->isRequired()
+                                                                                                       ->treatNullLike(array())
+                                                                                                       ->defaultValue($defaults['filters']['css']['args'])
+                                                                                                       ->scalarPrototype()->end()
+                                                                                               ->end()
+                                                                                       ->end()
+                                                                               ->end()
+                                                                       ->end()
+                                                                       ->arrayNode('js')
+                                                                               #XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+                                                                               ->addDefaultChildrenIfNoneSet()
+                                                                               ->arrayPrototype()
+                                                                                       ->children()
+                                                                                               ->scalarNode('class')
+                                                                                                       ->isRequired()
+                                                                                                       ->defaultValue($defaults['filters']['js']['class'])
+                                                                                               ->end()
+                                                                                               ->arrayNode('args')
+                                                                                                       ->isRequired()
+                                                                                                       ->treatNullLike(array())
+                                                                                                       ->defaultValue($defaults['filters']['js']['args'])
+                                                                                                       ->scalarPrototype()->end()
+                                                                                               ->end()
+                                                                                       ->end()
+                                                                               ->end()
+                                                                       ->end()
+                                                                       ->arrayNode('img')
+                                                                               #XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+                                                                               ->addDefaultChildrenIfNoneSet()
+                                                                               ->arrayPrototype()
+                                                                                       ->children()
+                                                                                               ->scalarNode('class')
+                                                                                                       ->isRequired()
+                                                                                                       ->defaultValue($defaults['filters']['img']['class'])
+                                                                                               ->end()
+                                                                                               ->arrayNode('args')
+                                                                                                       ->isRequired()
+                                                                                                       ->treatNullLike(array())
+                                                                                                       ->defaultValue($defaults['filters']['img']['args'])
+                                                                                                       ->scalarPrototype()->end()
+                                                                                               ->end()
+                                                                                       ->end()
+                                                                               ->end()
+                                                                       ->end()
+                                                               ->end()

                                                        ->end()
                                                        ->end()

-                                                       ->scalarNode('prefix')->defaultValue($this->projectDir)->end()
-                                                       ->scalarNode('scheme')->defaultValue('https://')->end()
-                                                       ->integerNode('timeout')->min(0)->defaultValue((int)ini_get('default_socket_timeout'))->end()
-                                                       ->scalarNode('agent')->defaultValue(ini_get('user_agent'))->end()
-                                                       ->integerNode('redirect')->min(1)->defaultValue(20)->end()
-                                               ->end()
-                                       ->end()
-                                       ->arrayNode('rapsys_pack_cpackfilter')
-                                               ->children()
-                                                       ->scalarNode('bin')->defaultValue(function () use ($finder) { return $finder->find('cpack', '/usr/local/bin/cpack'); })->end()
-                                               ->end()
-                                       ->end()
-                                       ->arrayNode('rapsys_pack_jpackfilter')
-                                               ->children()
-                                                       ->scalarNode('bin')->defaultValue(function () use ($finder) { return $finder->find('jpack', '/usr/local/bin/jpack'); })->end()

                                                ->end()
                                        ->end()
                                ->end()
                                                ->end()
                                        ->end()
                                ->end()