Cleanup trailing extra equals from hash method result

[packbundle] / Util / SluggerUtil.php

diff --git a/Util/SluggerUtil.php b/Util/SluggerUtil.php
index 5f7d76d7dff7539fa280b3190f1f93641257c246..0ff32c59ac1f7ac6c20945bf62083517510c355e 100644 (file)
--- a/Util/SluggerUtil.php
+++ b/Util/SluggerUtil.php
@@ -46,7 +46,7 @@ class SluggerUtil {
         */
        public function __construct(protected string $secret) {
                //Without range
         */
        public function __construct(protected string $secret) {
                //Without range

-               if (empty($range = $_ENV['RAPSYSPACK_RANGE']) || $range === 'Ch4ng3m3!') {
+               if (!isset($_ENV['RAPSYSPACK_RANGE']) || empty($range = $_ENV['RAPSYSPACK_RANGE']) || $range === 'Ch4ng3m3!') {

                        //Protect member variable setup
                        return;
                }
                        //Protect member variable setup
                        return;
                }


@@ -116,7 +116,7 @@ class SluggerUtil {
                //Return hashed data
                //XXX: we use hash_hmac with md5 hash
                //XXX: crypt was dropped because it provided identical signature for string starting with same pattern
                //Return hashed data
                //XXX: we use hash_hmac with md5 hash
                //XXX: crypt was dropped because it provided identical signature for string starting with same pattern

-               return str_replace(['+','/'], ['-','_'], base64_encode(hash_hmac('md5', $data, $this->secret, true)));
+               return str_replace(['+','/','='], ['-','_',''], base64_encode(hash_hmac('md5', $data, $this->secret, true)));

        }
 
        /**
        }
 
        /**


@@ -162,7 +162,7 @@ class SluggerUtil {
         * Convert string to safe slug
         *
         * @param string $data The data string
         * Convert string to safe slug
         *
         * @param string $data The data string

-        * @param string $separator The separator string 
+        * @param string $separator The separator string

         * @return ?string The slugged data
         */
        function slug(?string $data, string $separator = '-'): ?string {
         * @return ?string The slugged data
         */
        function slug(?string $data, string $separator = '-'): ?string {