Fix default configuration tree

Use bundle default config if not set as parameter

diff --git a/DependencyInjection/Configuration.php b/DependencyInjection/Configuration.php
index 1ea8231b43f7cb71c996118f1e6320d99bf9975a..341f178a8fceb01cb2e9fe3f208d9d3dabc5a762 100644 (file)
--- a/DependencyInjection/Configuration.php
+++ b/DependencyInjection/Configuration.php
@@ -60,13 +60,16 @@ class Configuration implements ConfigurationInterface {
                        ],
                        'filter' => [
                                'css' => [
                        ],
                        'filter' => [
                                'css' => [

-                                       'Rapsys\PackBundle\Twig\Filter\CPackFilter' => [$finder->find('cpack', '/usr/local/bin/cpack')]
+                                       'class' => 'Rapsys\PackBundle\Twig\Filter\CPackFilter',
+                                       'args' => [ $finder->find('cpack', '/usr/local/bin/cpack') ]

                                ],
                                'js' => [
                                ],
                                'js' => [

-                                       'Rapsys\PackBundle\Twig\Filter\JPackFilter' => [$finder->find('jpack', '/usr/local/bin/jpack')]
+                                       'class' => 'Rapsys\PackBundle\Twig\Filter\JPackFilter',
+                                       'args' => [ $finder->find('jpack', '/usr/local/bin/jpack') ]

                                ],
                                'img' => [
                                ],
                                'img' => [

-                                       'Rapsys\PackBundle\Twig\Filter\IPackFilter' => []
+                                       'class' => 'Rapsys\PackBundle\Twig\Filter\IPackFilter',
+                                       'args' => []

                                ],
                        ]
                ];
                                ],
                        ]
                ];


@@ -75,11 +78,9 @@ class Configuration implements ConfigurationInterface {
                $treeBuilder
                        //Parameters
                        ->root('parameters')
                $treeBuilder
                        //Parameters
                        ->root('parameters')

-                               ->isRequired()

                                ->addDefaultsIfNotSet()
                                ->children()
                                        ->arrayNode('rapsys_pack')
                                ->addDefaultsIfNotSet()
                                ->children()
                                        ->arrayNode('rapsys_pack')

-                                               ->isRequired()

                                                ->addDefaultsIfNotSet()
                                                ->children()
                                                        ->arrayNode('config')
                                                ->addDefaultsIfNotSet()
                                                ->children()
                                                        ->arrayNode('config')


@@ -107,22 +108,58 @@ class Configuration implements ConfigurationInterface {
                                                                ->addDefaultsIfNotSet()
                                                                ->children()
                                                                        ->arrayNode('css')
                                                                ->addDefaultsIfNotSet()
                                                                ->children()
                                                                        ->arrayNode('css')

-                                                                               ->isRequired()
-                                                                               ->treatNullLike(array())
-                                                                               ->scalarPrototype()->end()
-                                                                               ->defaultValue($defaults['filter']['css'])
+                                                                               #XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+                                                                               ->addDefaultChildrenIfNoneSet()
+                                                                               ->arrayPrototype()
+                                                                                       ->children()
+                                                                                               ->scalarNode('class')
+                                                                                                       ->isRequired()
+                                                                                                       ->defaultValue($defaults['filter']['css']['class'])
+                                                                                               ->end()
+                                                                                               ->arrayNode('args')
+                                                                                                       ->isRequired()
+                                                                                                       ->treatNullLike(array())
+                                                                                                       ->defaultValue($defaults['filter']['css']['args'])
+                                                                                                       ->scalarPrototype()->end()
+                                                                                               ->end()
+                                                                                       ->end()
+                                                                               ->end()

                                                                        ->end()
                                                                        ->arrayNode('js')
                                                                        ->end()
                                                                        ->arrayNode('js')

-                                                                               ->isRequired()
-                                                                               ->treatNullLike(array())
-                                                                               ->scalarPrototype()->end()
-                                                                               ->defaultValue($defaults['filter']['js'])
+                                                                               #XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+                                                                               ->addDefaultChildrenIfNoneSet()
+                                                                               ->arrayPrototype()
+                                                                                       ->children()
+                                                                                               ->scalarNode('class')
+                                                                                                       ->isRequired()
+                                                                                                       ->defaultValue($defaults['filter']['js']['class'])
+                                                                                               ->end()
+                                                                                               ->arrayNode('args')
+                                                                                                       ->isRequired()
+                                                                                                       ->treatNullLike(array())
+                                                                                                       ->defaultValue($defaults['filter']['js']['args'])
+                                                                                                       ->scalarPrototype()->end()
+                                                                                               ->end()
+                                                                                       ->end()
+                                                                               ->end()

                                                                        ->end()
                                                                        ->arrayNode('img')
                                                                        ->end()
                                                                        ->arrayNode('img')

-                                                                               ->isRequired()
-                                                                               ->treatNullLike(array())
-                                                                               ->scalarPrototype()->end()
-                                                                               ->defaultValue($defaults['filter']['img'])
+                                                                               #XXX: undocumented, see Symfony/Component/Config/Definition/Builder/ArrayNodeDefinition.php +513
+                                                                               ->addDefaultChildrenIfNoneSet()
+                                                                               ->arrayPrototype()
+                                                                                       ->children()
+                                                                                               ->scalarNode('class')
+                                                                                                       ->isRequired()
+                                                                                                       ->defaultValue($defaults['filter']['img']['class'])
+                                                                                               ->end()
+                                                                                               ->arrayNode('args')
+                                                                                                       ->isRequired()
+                                                                                                       ->treatNullLike(array())
+                                                                                                       ->defaultValue($defaults['filter']['img']['args'])
+                                                                                                       ->scalarPrototype()->end()
+                                                                                               ->end()
+                                                                                       ->end()
+                                                                               ->end()

                                                                        ->end()
                                                                ->end()
                                                        ->end()
                                                                        ->end()
                                                                ->end()
                                                        ->end()

diff --git a/DependencyInjection/RapsysPackExtension.php b/DependencyInjection/RapsysPackExtension.php
index 97bb11f3b23c0200688e169dda382edc6cfa7a0f..5397036876f65a11a5ab899c58aea423977d2d6b 100644 (file)
--- a/DependencyInjection/RapsysPackExtension.php
+++ b/DependencyInjection/RapsysPackExtension.php
@@ -24,6 +24,11 @@ class RapsysPackExtension extends Extension {
                //Load configuration
                $configuration = $this->getConfiguration($configs, $container);
                $config = $this->processConfiguration($configuration, $configs);
                //Load configuration
                $configuration = $this->getConfiguration($configs, $container);
                $config = $this->processConfiguration($configuration, $configs);

+
+               //Set default config in parameter
+               if (!$container->hasParameter($alias = $this->getAlias())) {
+                       $container->setParameter($alias, $config[$alias]);
+               }

        }
 
        /**
        }
 
        /**