]> Raphaël G. Git Repositories - packbundle/commitdiff
Add todo about new symfony 4.4 getPublicDir bundle member function
authorRaphaël Gertz <git@rapsys.eu>
Wed, 27 Nov 2019 16:38:30 +0000 (17:38 +0100)
committerRaphaël Gertz <git@rapsys.eu>
Wed, 27 Nov 2019 16:38:30 +0000 (17:38 +0100)
Asset/PathPackage.php
Twig/PackTokenParser.php

index 5fa69e24ef5547be261cc3f5e4cccc660ed0c8b0..1a975c5e9e6cc5bf6dae3346a070346529d7fb26 100644 (file)
@@ -31,6 +31,8 @@ class PathPackage extends BasePackage {
        }
 
        /**
+        * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ?
+        * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure
         * {@inheritdoc}
         */
        public function getUrl($path) {
index 9fffebb585dce3c5051159c03a28590467a9a471..c4bbe4cb7c49a3b0237a444611432bb3c4ac7052 100644 (file)
@@ -328,6 +328,9 @@ class PackTokenParser extends AbstractTokenParser {
         * @param \Exception prev   The previous exception
         *
         * @return string The resolved file path
+        *
+        * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ?
+        * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure
         */
        public function getLocated($file, int $lineno = 0, Source $source = null, \Exception $prev = null) {
                /*TODO: add a @jquery magic feature ?