]> Raphaƫl G. Git Repositories - userbundle/blobdiff - Controller/DefaultController.php
Switch to new getRecipientName user entity function
[userbundle] / Controller / DefaultController.php
index 5c3c51c3e6ff3226b2d2776f868d3d3c6298998e..c431b5d8af1688ee6cf1230bd1b458477976d526 100644 (file)
@@ -13,10 +13,9 @@ namespace Rapsys\UserBundle\Controller;
 
 use Doctrine\Bundle\DoctrineBundle\Registry;
 use Doctrine\ORM\EntityManagerInterface;
+use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
 use Psr\Log\LoggerInterface;
 use Symfony\Bridge\Twig\Mime\TemplatedEmail;
-use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
-use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\Form\FormError;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
@@ -28,208 +27,13 @@ use Symfony\Component\Routing\Generator\UrlGeneratorInterface;
 use Symfony\Component\Routing\RouterInterface;
 use Symfony\Component\Security\Core\Encoder\UserPasswordEncoderInterface;
 use Symfony\Component\Security\Http\Authentication\AuthenticationUtils;
-use Symfony\Component\Translation\TranslatorInterface;
 
 use Rapsys\PackBundle\Util\SluggerUtil;
-use Rapsys\UserBundle\RapsysUserBundle;
 
+/**
+ * {@inheritdoc}
+ */
 class DefaultController extends AbstractController {
-       //Config array
-       protected $config;
-
-       //Translator instance
-       protected $translator;
-
-       /**
-        * Constructor
-        *
-        * @TODO: move all canonical and other view related stuff in an user AbstractController like in RapsysAir render feature !!!!
-        *
-        * @param ContainerInterface $container The containter instance
-        * @param RouterInterface $router The router instance
-        * @param TranslatorInterface $translator The translator instance
-        */
-       public function __construct(ContainerInterface $container, RouterInterface $router, TranslatorInterface $translator) {
-               //Retrieve config
-               $this->config = $container->getParameter(self::getAlias());
-
-               //Set the translator
-               $this->translator = $translator;
-
-               //Get request stack
-               $stack = $container->get('request_stack');
-
-               //Get current request
-               $request = $stack->getCurrentRequest();
-
-               //Get current locale
-               $currentLocale = $request->getLocale();
-
-               //Set locale
-               $this->config['context']['locale'] = str_replace('_', '-', $currentLocale);
-
-               //Set translate array
-               $translates = [];
-
-               //Look for keys to translate
-               if (!empty($this->config['translate'])) {
-                       //Iterate on keys to translate
-                       foreach($this->config['translate'] as $translate) {
-                               //Set tmp
-                               $tmp = null;
-                               //Iterate on keys
-                               foreach(array_reverse(explode('.', $translate)) as $curkey) {
-                                       $tmp = array_combine([$curkey], [$tmp]);
-                               }
-                               //Append tree
-                               $translates = array_replace_recursive($translates, $tmp);
-                       }
-               }
-
-               //Inject every requested route in view and mail context
-               foreach($this->config as $tag => $current) {
-                       //Look for entry with title subkey
-                       if (!empty($current['title'])) {
-                               //Translate title value
-                               $this->config[$tag]['title'] = $translator->trans($current['title']);
-                       }
-
-                       //Look for entry with route subkey
-                       if (!empty($current['route'])) {
-                               //Generate url for both view and mail
-                               foreach(['view', 'mail'] as $view) {
-                                       //Check that context key is usable
-                                       if (isset($current[$view]['context']) && is_array($current[$view]['context'])) {
-                                               //Merge with global context
-                                               $this->config[$tag][$view]['context'] = array_replace_recursive($this->config['context'], $this->config[$tag][$view]['context']);
-
-                                               //Process every routes
-                                               foreach($current['route'] as $route => $key) {
-                                                       //With confirm route
-                                                       if ($route == 'confirm') {
-                                                               //Skip route as it requires some parameters
-                                                               continue;
-                                                       }
-
-                                                       //Set value
-                                                       $value = $router->generate(
-                                                               $this->config['route'][$route]['name'],
-                                                               $this->config['route'][$route]['context'],
-                                                               //Generate absolute url for mails
-                                                               $view=='mail'?UrlGeneratorInterface::ABSOLUTE_URL:UrlGeneratorInterface::ABSOLUTE_PATH
-                                                       );
-
-                                                       //Multi level key
-                                                       if (strpos($key, '.') !== false) {
-                                                               //Set tmp
-                                                               $tmp = $value;
-
-                                                               //Iterate on key
-                                                               foreach(array_reverse(explode('.', $key)) as $curkey) {
-                                                                       $tmp = array_combine([$curkey], [$tmp]);
-                                                               }
-
-                                                               //Set value
-                                                               $this->config[$tag][$view]['context'] = array_replace_recursive($this->config[$tag][$view]['context'], $tmp);
-                                                       //Single level key
-                                                       } else {
-                                                               //Set value
-                                                               $this->config[$tag][$view]['context'][$key] = $value;
-                                                       }
-                                               }
-
-                                               //Look for successful intersections
-                                               if (!empty(array_intersect_key($translates, $this->config[$tag][$view]['context']))) {
-                                                       //Iterate on keys to translate
-                                                       foreach($this->config['translate'] as $translate) {
-                                                               //Set keys
-                                                               $keys = explode('.', $translate);
-
-                                                               //Set tmp
-                                                               $tmp = $this->config[$tag][$view]['context'];
-
-                                                               //Iterate on keys
-                                                               foreach($keys as $curkey) {
-                                                                       //Without child key
-                                                                       if (!isset($tmp[$curkey])) {
-                                                                               //Skip to next key
-                                                                               continue(2);
-                                                                       }
-
-                                                                       //Get child key
-                                                                       $tmp = $tmp[$curkey];
-                                                               }
-
-                                                               //Translate tmp value
-                                                               $tmp = $translator->trans($tmp);
-
-                                                               //Iterate on keys
-                                                               foreach(array_reverse($keys) as $curkey) {
-                                                                       //Set parent key
-                                                                       $tmp = array_combine([$curkey], [$tmp]);
-                                                               }
-
-                                                               //Set value
-                                                               $this->config[$tag][$view]['context'] = array_replace_recursive($this->config[$tag][$view]['context'], $tmp);
-                                                       }
-                                               }
-
-                                               //With view context
-                                               if ($view == 'view') {
-                                                       //Get context path
-                                                       $pathInfo = $router->getContext()->getPathInfo();
-
-                                                       //Iterate on locales excluding current one
-                                                       foreach($this->config['locales'] as $locale) {
-                                                               //Set titles
-                                                               $titles = [];
-
-                                                               //Iterate on other locales
-                                                               foreach(array_diff($this->config['locales'], [$locale]) as $other) {
-                                                                       $titles[$other] = $translator->trans($this->config['languages'][$locale], [], null, $other);
-                                                               }
-
-                                                               //Retrieve route matching path
-                                                               $route = $router->match($pathInfo);
-
-                                                               //Get route name
-                                                               $name = $route['_route'];
-
-                                                               //Unset route name
-                                                               unset($route['_route']);
-
-                                                               //With current locale
-                                                               if ($locale == $currentLocale) {
-                                                                       //Set locale locales context
-                                                                       $this->config[$tag][$view]['context']['canonical'] = $router->generate($name, ['_locale' => $locale]+$route, UrlGeneratorInterface::ABSOLUTE_URL);
-                                                               } else {
-                                                                       //Set locale locales context
-                                                                       $this->config[$tag][$view]['context']['alternates'][$locale] = [
-                                                                               'absolute' => $router->generate($name, ['_locale' => $locale]+$route, UrlGeneratorInterface::ABSOLUTE_URL),
-                                                                               'relative' => $router->generate($name, ['_locale' => $locale]+$route),
-                                                                               'title' => implode('/', $titles),
-                                                                               'translated' => $translator->trans($this->config['languages'][$locale], [], null, $locale)
-                                                                       ];
-                                                               }
-
-                                                               //Add shorter locale
-                                                               if (empty($this->config[$tag][$view]['context']['alternates'][$slocale = substr($locale, 0, 2)])) {
-                                                                       //Add shorter locale
-                                                                       $this->config[$tag][$view]['context']['alternates'][$slocale] = [
-                                                                               'absolute' => $router->generate($name, ['_locale' => $locale]+$route, UrlGeneratorInterface::ABSOLUTE_URL),
-                                                                               'relative' => $router->generate($name, ['_locale' => $locale]+$route),
-                                                                               'title' => implode('/', $titles),
-                                                                               'translated' => $translator->trans($this->config['languages'][$locale], [], null, $locale)
-                                                                       ];
-                                                               }
-                                                       }
-                                               }
-                                       }
-                               }
-                       }
-               }
-       }
-
        /**
         * Confirm account from mail link
         *
@@ -322,22 +126,6 @@ class DefaultController extends AbstractController {
                        throw $this->createAccessDeniedException($this->translator->trans('Unable to access user: %mail%', ['%mail%' => $smail]));
                }
 
-               //Create the RegisterType form and give the proper parameters
-               $editForm = $this->createForm($this->config['register']['view']['form'], $user, [
-                       //Set action to register route name and context
-                       'action' => $this->generateUrl($this->config['route']['edit']['name'], ['mail' => $smail, 'hash' => $slugger->hash($smail)]+$this->config['route']['edit']['context']),
-                       //Set civility class
-                       'civility_class' => $this->config['class']['civility'],
-                       //Set civility default
-                       'civility_default' => $doctrine->getRepository($this->config['class']['civility'])->findOneByTitle($this->config['default']['civility']),
-                       //Disable mail
-                       'mail' => $this->isGranted('ROLE_ADMIN'),
-                       //Disable password
-                       'password' => false,
-                       //Set method
-                       'method' => 'POST'
-               ]);
-
                //Create the RegisterType form and give the proper parameters
                $edit = $this->createForm($this->config['edit']['view']['edit'], $user, [
                        //Set action to register route name and context
@@ -352,7 +140,7 @@ class DefaultController extends AbstractController {
                        'password' => false,
                        //Set method
                        'method' => 'POST'
-               ]);
+               ]+$this->config['edit']['field']);
 
                //With admin role
                if ($this->isGranted('ROLE_ADMIN')) {
@@ -415,14 +203,21 @@ class DefaultController extends AbstractController {
                                //Queue snippet save
                                $manager->persist($data);
 
-                               //Flush to get the ids
-                               $manager->flush();
+                               //Try saving in database
+                               try {
+                                       //Flush to get the ids
+                                       $manager->flush();
 
-                               //Add notice
-                               $this->addFlash('notice', $this->translator->trans('Account %mail% updated', ['%mail%' => $mail = $data->getMail()]));
+                                       //Add notice
+                                       $this->addFlash('notice', $this->translator->trans('Account %mail% updated', ['%mail%' => $mail = $data->getMail()]));
 
-                               //Redirect to cleanup the form
-                               return $this->redirectToRoute($this->config['route']['edit']['name'], ['mail' => $smail = $slugger->short($mail), 'hash' => $slugger->hash($smail)]+$this->config['route']['edit']['context']);
+                                       //Redirect to cleanup the form
+                                       return $this->redirectToRoute($this->config['route']['edit']['name'], ['mail' => $smail = $slugger->short($mail), 'hash' => $slugger->hash($smail)]+$this->config['route']['edit']['context']);
+                               //Catch double slug or mail
+                               } catch (UniqueConstraintViolationException $e) {
+                                       //Add error message mail already exists
+                                       $this->addFlash('error', $this->translator->trans('Account %mail% or with slug %slug% already exists', ['%mail%' => $data->getMail(), '%slug%' => $slug]));
+                               }
                        }
                }
 
@@ -596,7 +391,7 @@ class DefaultController extends AbstractController {
                                                $recoverMail['context']['recipient_mail'] = $user->getMail();
 
                                                //Set recipient_name
-                                               $recoverMail['context']['recipient_name'] = trim($user->getForename().' '.$user->getSurname().($user->getPseudonym()?' ('.$user->getPseudonym().')':''));
+                                               $recoverMail['context']['recipient_name'] = $user->getRecipientName();
 
                                                //Init subject context
                                                $subjectContext = $slugger->flatten(array_replace_recursive($this->config['recover']['view']['context'], $recoverMail['context']), null, '.', '%', '%');
@@ -749,11 +544,28 @@ class DefaultController extends AbstractController {
         * @return Response The response
         */
        public function register(Request $request, Registry $doctrine, UserPasswordEncoderInterface $encoder, EntityManagerInterface $manager, SluggerUtil $slugger, MailerInterface $mailer, LoggerInterface $logger, $mail, $field, $hash): Response {
-               //Init reflection
-               $reflection = new \ReflectionClass($this->config['class']['user']);
-
-               //Create new user
-               $user = $reflection->newInstance();
+               //With mail
+               if (!empty($_POST['register']['mail'])) {
+                       //Log new user infos
+                       $logger->emergency(
+                               $this->translator->trans(
+                                       'register: mail=%mail% locale=%locale% confirm=%confirm%',
+                                       [
+                                               '%mail%' => $postMail = $_POST['register']['mail'],
+                                               '%locale%' => $request->getLocale(),
+                                               '%confirm%' => $this->get('router')->generate(
+                                                       $this->config['route']['confirm']['name'],
+                                                       //Prepend subscribe context with tag
+                                                       [
+                                                               'mail' => $postSmail = $slugger->short($postMail),
+                                                               'hash' => $slugger->hash($postSmail)
+                                                       ]+$this->config['route']['confirm']['context'],
+                                                       UrlGeneratorInterface::ABSOLUTE_URL
+                                               )
+                                       ]
+                               )
+                       );
+               }
 
                //With mail and field
                if (!empty($field) && !empty($hash)) {
@@ -775,26 +587,26 @@ class DefaultController extends AbstractController {
                                        throw new BadRequestHttpException($this->translator->trans('Invalid %field% field: %value%', ['%field%' => 'mail', '%value%' => $smail]));
                                }
 
-                               //Set mail
-                               $user->setMail($mail);
-
                                //With existing registrant
                                if ($existing = $doctrine->getRepository($this->config['class']['user'])->findOneByMail($mail)) {
                                        //With disabled existing
                                        if ($existing->isDisabled()) {
                                                //Render view
-                                               return $this->render(
+                                               $response = $this->render(
                                                        //Template
                                                        $this->config['register']['view']['name'],
                                                        //Context
-                                                       ['title' => $this->translator->trans('Access denied'), 'disabled' => 1]+$this->config['register']['view']['context'],
-                                                       //Set 403
-                                                       new Response('', 403)
+                                                       ['title' => $this->translator->trans('Access denied'), 'disabled' => 1]+$this->config['register']['view']['context']
                                                );
+
+                                               //Set 403
+                                               $response->setStatusCode(403);
+
+                                               //Return response
+                                               return $response;
                                        //With unactivated existing
                                        } elseif (!$existing->isActivated()) {
                                                //Set mail shortcut
-                                               //TODO: change for activate ???
                                                $activateMail =& $this->config['register']['mail'];
 
                                                //Generate each route route
@@ -821,7 +633,7 @@ class DefaultController extends AbstractController {
                                                $activateMail['context']['recipient_mail'] = $existing->getMail();
 
                                                //Set recipient name
-                                               $activateMail['context']['recipient_name'] = implode(' ', [$existing->getForename(), $existing->getSurname(), $existing->getPseudonym()?'('.$existing->getPseudonym().')':'']);
+                                               $activateMail['context']['recipient_name'] = $existing->getRecipientName();
 
                                                //Init subject context
                                                $subjectContext = $slugger->flatten(array_replace_recursive($this->config['register']['view']['context'], $activateMail['context']), null, '.', '%', '%');
@@ -912,6 +724,12 @@ class DefaultController extends AbstractController {
                        $field = [];
                }
 
+               //Init reflection
+               $reflection = new \ReflectionClass($this->config['class']['user']);
+
+               //Create new user
+               $user = $reflection->newInstance(strval($mail));
+
                //Create the RegisterType form and give the proper parameters
                $form = $this->createForm($this->config['register']['view']['form'], $user, $field+[
                        //Set action to register route name and context
@@ -924,7 +742,7 @@ class DefaultController extends AbstractController {
                        'mail' => true,
                        //Set method
                        'method' => 'POST'
-               ]);
+               ]+$this->config['register']['field']);
 
                if ($request->isMethod('POST')) {
                        //Refill the fields in case the form is not valid.
@@ -952,26 +770,8 @@ class DefaultController extends AbstractController {
                                //Set mail shortcut
                                $registerMail =& $this->config['register']['mail'];
 
-                               //Extract names and pseudonym from mail
-                               $names = explode(' ', $pseudonym = ucwords(trim(preg_replace('/[^a-zA-Z]+/', ' ', current(explode('@', $data->getMail()))))));
-
-                               //Set pseudonym
-                               $user->setPseudonym($user->getPseudonym()??$pseudonym);
-
-                               //Set forename
-                               $user->setForename($user->getForename()??$names[0]);
-
-                               //Set surname
-                               $user->setSurname($user->getSurname()??$names[1]??$names[0]);
-
                                //Set password
-                               $user->setPassword($encoder->encodePassword($user, $user->getPassword()??$data->getMail()));
-
-                               //Set created
-                               $user->setCreated(new \DateTime('now'));
-
-                               //Set updated
-                               $user->setUpdated(new \DateTime('now'));
+                               $user->setPassword($encoder->encodePassword($user, $user->getPassword()));
 
                                //Persist user
                                $manager->persist($user);
@@ -1011,30 +811,11 @@ class DefaultController extends AbstractController {
                                        }
                                }
 
-                               //XXX: DEBUG: remove me
-                               //die($registerMail['context']['confirm_url']);
-
-                               //Log new user infos
-                               //XXX: useless ???
-                               $logger->emergency(
-                                       $this->translator->trans(
-                                               'newuser:mail=%mail%|locale=%locale%|confirm=%confirm%',
-                                               [
-                                                       '%mail%' => $data->getMail(),
-                                                       '%locale%' => $request->getLocale(),
-                                                       '%confirm%' => $registerMail['context'][$this->config['register']['route']['confirm']]
-                                               ]
-                                       )
-                               );
-
                                //Set recipient_name
                                $registerMail['context']['recipient_mail'] = $data->getMail();
 
                                //Set recipient name
-                               $registerMail['context']['recipient_name'] = '';
-
-                               //Set recipient name
-                               $registerMail['context']['recipient_name'] = implode(' ', [$data->getForename(), $data->getSurname(), $data->getPseudonym()?'('.$data->getPseudonym().')':'']);
+                               $registerMail['context']['recipient_name'] = $data->getRecipientName();
 
                                //Init subject context
                                $subjectContext = $slugger->flatten(array_replace_recursive($this->config['register']['view']['context'], $registerMail['context']), null, '.', '%', '%');
@@ -1081,7 +862,7 @@ class DefaultController extends AbstractController {
                                                $form->get('mail')->addError(new FormError($this->translator->trans('Account %mail% tried subscribe but unable to contact', ['%mail%' => $data->getMail()])));
                                        }
                                //Catch double subscription
-                               } catch (\Doctrine\DBAL\Exception\UniqueConstraintViolationException $e) {
+                               } catch (UniqueConstraintViolationException $e) {
                                        //Add error message mail already exists
                                        $this->addFlash('error', $this->translator->trans('Account %mail% already exists', ['%mail%' => $mail]));
                                }
@@ -1096,11 +877,4 @@ class DefaultController extends AbstractController {
                        ['form' => $form->createView(), 'sent' => $request->query->get('sent', 0)]+$this->config['register']['view']['context']
                );
        }
-
-       /**
-        * {@inheritdoc}
-        */
-       public function getAlias(): string {
-               return RapsysUserBundle::getAlias();
-       }
 }