Fix extraction of forename and surname from mail when empty

[userbundle] / Entity / User.php

diff --git a/Entity/User.php b/Entity/User.php
index 8e6a671f78aee694710f634a49856d0f80d45e78..9ccad72e5a17fb405bfa0b5f8d2dc163e951d55a 100644 (file)
--- a/Entity/User.php
+++ b/Entity/User.php
@@ -12,6 +12,7 @@
 namespace Rapsys\UserBundle\Entity;
 
 use Doctrine\Common\Collections\ArrayCollection;
+use Doctrine\ORM\Event\PreUpdateEventArgs;
 use Symfony\Component\Security\Core\User\UserInterface;
 
 use Rapsys\UserBundle\Entity\Civility;
@@ -31,11 +32,6 @@ class User implements UserInterface, \Serializable {
         */
        protected $mail;
 
-       /**
-        * @var string
-        */
-       protected $pseudonym;
-
        /**
         * @var string
         */
@@ -83,10 +79,27 @@ class User implements UserInterface, \Serializable {
 
        /**
         * Constructor
-        */
-       public function __construct() {
+        *
+        * @param string $mail The user mail
+        */
+       public function __construct(string $mail) {
+               //Set defaults
+               if (!empty($this->mail = $mail)) {
+                       //Extract names from mail
+                       $names = explode(' ', ucwords(trim(preg_replace('/[^a-zA-Z]+/', ' ', current(explode('@', $mail))))));
+                       $this->forename = $names[0];
+                       $this->surname = $names[1]??$names[0];
+               } else {
+                       $this->forename = '';
+                       $this->surname = '';
+               }
+               $this->password = $mail;
                $this->active = false;
                $this->disabled = false;
+               $this->created = new \DateTime('now');
+               $this->updated = new \DateTime('now');
+
+               //Set collections
                $this->groups = new ArrayCollection();
        }
 
@@ -106,8 +119,19 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setMail(string $mail) {
-               $this->mail = $mail;
+       public function setMail(string $mail): User {
+               //With mail
+               if (!empty($this->mail = $mail)) {
+                       //Without forename and surname
+                       if (empty($this->forename) && empty($this->surname)) {
+                               //Extract names from mail
+                               $names = explode(' ', ucwords(trim(preg_replace('/[^a-zA-Z]+/', ' ', current(explode('@', $mail))))));
+                               //Set forename
+                               $this->forename = $names[0];
+                               //Set surname
+                               $this->surname = $names[1]??$names[0];
+                       }
+               }
 
                return $this;
        }
@@ -117,32 +141,10 @@ class User implements UserInterface, \Serializable {
         *
         * @return string
         */
-       public function getMail(): ?string {
+       public function getMail(): string {
                return $this->mail;
        }
 
-       /**
-        * Set pseudonym
-        *
-        * @param string $pseudonym
-        *
-        * @return User
-        */
-       public function setPseudonym(string $pseudonym) {
-               $this->pseudonym = $pseudonym;
-
-               return $this;
-       }
-
-       /**
-        * Get pseudonym
-        *
-        * @return string
-        */
-       public function getPseudonym(): ?string {
-               return $this->pseudonym;
-       }
-
        /**
         * Set forename
         *
@@ -150,7 +152,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setForename(string $forename) {
+       public function setForename(string $forename): User {
                $this->forename = $forename;
 
                return $this;
@@ -161,7 +163,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return string
         */
-       public function getForename(): ?string {
+       public function getForename(): string {
                return $this->forename;
        }
 
@@ -172,7 +174,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setSurname(string $surname) {
+       public function setSurname(string $surname): User {
                $this->surname = $surname;
 
                return $this;
@@ -183,7 +185,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return string
         */
-       public function getSurname(): ?string {
+       public function getSurname(): string {
                return $this->surname;
        }
 
@@ -194,7 +196,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setPassword(string $password) {
+       public function setPassword(string $password): User {
                $this->password = $password;
 
                return $this;
@@ -218,7 +220,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setActive(bool $active) {
+       public function setActive(bool $active): User {
                $this->active = $active;
 
                return $this;
@@ -240,7 +242,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setDisabled(bool $disabled) {
+       public function setDisabled(bool $disabled): User {
                $this->disabled = $disabled;
 
                return $this;
@@ -262,7 +264,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setCreated(\DateTime $created) {
+       public function setCreated(\DateTime $created): User {
                $this->created = $created;
 
                return $this;
@@ -284,7 +286,7 @@ class User implements UserInterface, \Serializable {
         *
         * @return User
         */
-       public function setUpdated(\DateTime $updated) {
+       public function setUpdated(\DateTime $updated): User {
                $this->updated = $updated;
 
                return $this;
@@ -302,7 +304,7 @@ class User implements UserInterface, \Serializable {
        /**
         * Set civility
         */
-       public function setCivility(Civility $civility) {
+       public function setCivility(Civility $civility): User {
                $this->civility = $civility;
 
                return $this;
@@ -413,10 +415,15 @@ class User implements UserInterface, \Serializable {
         */
        public function eraseCredentials(): void {}
 
+       /**
+        * {@inheritdoc}
+        */
        public function serialize(): string {
                return serialize([
                        $this->id,
                        $this->mail,
+                       $this->forename,
+                       $this->surname,
                        $this->password,
                        $this->active,
                        $this->disabled,
@@ -425,10 +432,15 @@ class User implements UserInterface, \Serializable {
                ]);
        }
 
+       /**
+        * {@inheritdoc}
+        */
        public function unserialize($serialized) {
                list(
                        $this->id,
                        $this->mail,
+                       $this->forename,
+                       $this->surname,
                        $this->password,
                        $this->active,
                        $this->disabled,
@@ -462,7 +474,7 @@ class User implements UserInterface, \Serializable {
        /**
         * {@inheritdoc}
         */
-       public function preUpdate(\Doctrine\ORM\Event\PreUpdateEventArgs $eventArgs) {
+       public function preUpdate(PreUpdateEventArgs $eventArgs) {
                //Check that we have an user instance
                if (($user = $eventArgs->getEntity()) instanceof User) {
                        //Set updated value