Set strict type

[userbundle] / Form / RegisterType.php

diff --git a/Form/RegisterType.php b/Form/RegisterType.php
index 7e3e9b9115c96347cd0f18dee91f90dbafbc5469..71a0dcd8742e0f4834e9cf55aeeaf0829ca94cf8 100644 (file)
--- a/Form/RegisterType.php
+++ b/Form/RegisterType.php
@@ -1,4 +1,13 @@
-<?php
+<?php declare(strict_types=1);
+
+/*
+ * This file is part of the Rapsys UserBundle package.
+ *
+ * (c) Raphaël Gertz <symfony@rapsys.eu>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */

 
 namespace Rapsys\UserBundle\Form;
 
 
 namespace Rapsys\UserBundle\Form;
 


@@ -14,34 +23,82 @@ use Symfony\Component\OptionsResolver\OptionsResolver;
 use Symfony\Component\Validator\Constraints\Email;
 use Symfony\Component\Validator\Constraints\NotBlank;
 
 use Symfony\Component\Validator\Constraints\Email;
 use Symfony\Component\Validator\Constraints\NotBlank;
 

+use Rapsys\UserBundle\Entity\Civility;
+

 class RegisterType extends AbstractType {
        /**
         * {@inheritdoc}
         */
 class RegisterType extends AbstractType {
        /**
         * {@inheritdoc}
         */

-       public function buildForm(FormBuilderInterface $builder, array $options) {
-               return $builder->add('mail', EmailType::class, array('attr' => array('placeholder' => 'Your mail address'), 'constraints' => array(new NotBlank(array('message' => 'Please provide your mail')), new Email(array('message' => 'Your mail doesn\'t seems to be valid')))))
-                       #'RapsysUserBundle:Title'
-                       ->add('title', EntityType::class, array('class' => $options['class_title'], 'choice_label' => 'title', 'attr' => array('placeholder' => 'Your title'), 'constraints' => array(new NotBlank(array('message' => 'Please provide your title')))))
-                       ->add('pseudonym', TextType::class, array('attr' => array('placeholder' => 'Your pseudonym'), 'constraints' => array(new NotBlank(array('message' => 'Please provide your pseudonym')))))
-                       ->add('forename', TextType::class, array('attr' => array('placeholder' => 'Your forename'), 'constraints' => array(new NotBlank(array('message' => 'Please provide your forename')))))
-                       ->add('surname', TextType::class, array('attr' => array('placeholder' => 'Your surname'), 'constraints' => array(new NotBlank(array('message' => 'Please provide your surname')))))
-                       ->add('password', RepeatedType::class, array('type' => PasswordType::class, 'invalid_message' => 'The password and confirmation must match', 'first_options' => array('attr' => array('placeholder' => 'Your password'), 'label' => 'Password'), 'second_options' => array('attr' => array('placeholder' => 'Your password confirmation'), 'label' => 'Confirm password'), 'options' => array('constraints' => array(new NotBlank(array('message' => 'Please provide your password'))))))
-                       ->add('submit', SubmitType::class, array('label' => 'Send', 'attr' => array('class' => 'submit')));
+       public function buildForm(FormBuilderInterface $builder, array $options): FormBuilderInterface {
+               //Create form
+               $form = $builder;
+
+               //Add extra mail field
+               if (!empty($options['mail'])) {
+                       $form->add('mail', EmailType::class, ['attr' => ['placeholder' => 'Your mail'], 'constraints' => [new NotBlank(['message' => 'Please provide your mail']), new Email(['message' => 'Your mail doesn\'t seems to be valid'])], 'required' => true]);
+               }
+
+               //Add extra password field
+               if (!empty($options['password'])) {
+                       $form->add('password', RepeatedType::class, ['type' => PasswordType::class, 'invalid_message' => 'The password and confirmation must match', 'first_options' => ['attr' => ['placeholder' => 'Your password'], 'label' => 'Password'], 'second_options' => ['attr' => ['placeholder' => 'Your password confirmation'], 'label' => 'Confirm password'], 'options' => ['constraints' => [new NotBlank(['message' => 'Please provide your password'])]], 'required' => true]);
+               }
+
+               //Add extra civility field
+               if (!empty($options['civility'])) {
+                       $form->add('civility', EntityType::class, ['class' => $options['civility_class'], 'attr' => ['placeholder' => 'Your civility'], 'choice_translation_domain' => true, 'empty_data' => $options['civility_default'], 'required' => true]);
+               }
+
+               //Add extra forename field
+               if (!empty($options['forename'])) {
+                       $form->add('forename', TextType::class, ['attr' => ['placeholder' => 'Your forename']]);
+               }
+
+               //Add extra surname field
+               if (!empty($options['surname'])) {
+                       $form->add('surname', TextType::class, ['attr' => ['placeholder' => 'Your surname']]);
+               }
+
+               //Add submit
+               $form->add('submit', SubmitType::class, ['label' => 'Send', 'attr' => ['class' => 'submit']]);
+
+               //Return form
+               return $form;

        }
 
        /**
         * {@inheritdoc}
         */
        }
 
        /**
         * {@inheritdoc}
         */

-       public function configureOptions(OptionsResolver $resolver) {
-               $resolver->setDefaults(['error_bubbling' => true]);
-               $resolver->setRequired('class_title');
-               $resolver->setAllowedTypes('class_title', 'string');
+       public function configureOptions(OptionsResolver $resolver): void {
+               //Set defaults
+               $resolver->setDefaults(['error_bubbling' => true, 'civility_class' => 'RapsysUserBundle:Civility', 'civility_default' => null, 'mail' => true, 'civility' => true, 'forename' => true, 'surname' => true, 'password' => true]);
+
+               //Add civility class
+               $resolver->setAllowedTypes('civility_class', 'string');
+
+               //Add civility default
+               //XXX: trigger strange error about table not existing is not specified in form create
+               $resolver->setAllowedTypes('civility_default', [Civility::class, 'null']);
+
+               //Add extra mail option
+               $resolver->setAllowedTypes('mail', 'boolean');
+
+               //Add extra civility option
+               $resolver->setAllowedTypes('civility', 'boolean');
+
+               //Add extra forename option
+               $resolver->setAllowedTypes('forename', 'boolean');
+
+               //Add extra surname option
+               $resolver->setAllowedTypes('surname', 'boolean');
+
+               //Add extra password option
+               $resolver->setAllowedTypes('password', 'boolean');

        }
 
        /**
         * {@inheritdoc}
         */
        }
 
        /**
         * {@inheritdoc}
         */

-       public function getName() {
+       public function getName(): string {

                return 'rapsys_user_register';
        }
 }
                return 'rapsys_user_register';
        }
 }