Update changelog.

[youtubedl] / test / test_download.py

diff --git a/test/test_download.py b/test/test_download.py
index 3eca333f269748cabb1f09b62a11f70ace25b3ac..23a66254d86ed2a68ee3ea54339838fda7d5dc71 100644 (file)
--- a/test/test_download.py
+++ b/test/test_download.py
@@ -7,17 +7,15 @@ import os
 import json
 import unittest
 import sys
 import json
 import unittest
 import sys

-import hashlib

 import socket
 import socket

+import binascii

 
 # Allow direct execution
 sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 
 
 # Allow direct execution
 sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
 

-import youtube_dl.FileDownloader
-import youtube_dl.InfoExtractors
+import youtube_dl.YoutubeDL

 from youtube_dl.utils import *
 
 from youtube_dl.utils import *
 

-DEF_FILE = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'tests.json')

 PARAMETERS_FILE = os.path.join(os.path.dirname(os.path.abspath(__file__)), "parameters.json")
 
 RETRIES = 3
 PARAMETERS_FILE = os.path.join(os.path.dirname(os.path.abspath(__file__)), "parameters.json")
 
 RETRIES = 3


@@ -38,21 +36,27 @@ def _try_rm(filename):
         if ose.errno != errno.ENOENT:
             raise
 
         if ose.errno != errno.ENOENT:
             raise
 

-class FileDownloader(youtube_dl.FileDownloader):
+md5 = lambda s: hashlib.md5(s.encode('utf-8')).hexdigest()
+
+class YoutubeDL(youtube_dl.YoutubeDL):

     def __init__(self, *args, **kwargs):
         self.to_stderr = self.to_screen
         self.processed_info_dicts = []
     def __init__(self, *args, **kwargs):
         self.to_stderr = self.to_screen
         self.processed_info_dicts = []

-        return youtube_dl.FileDownloader.__init__(self, *args, **kwargs)
+        super(YoutubeDL, self).__init__(*args, **kwargs)
+    def report_warning(self, message):
+        # Don't accept warnings during tests
+        raise ExtractorError(message)

     def process_info(self, info_dict):
         self.processed_info_dicts.append(info_dict)
     def process_info(self, info_dict):
         self.processed_info_dicts.append(info_dict)

-        return youtube_dl.FileDownloader.process_info(self, info_dict)
+        return super(YoutubeDL, self).process_info(info_dict)

 
 def _file_md5(fn):
     with open(fn, 'rb') as f:
         return hashlib.md5(f.read()).hexdigest()
 
 
 def _file_md5(fn):
     with open(fn, 'rb') as f:
         return hashlib.md5(f.read()).hexdigest()
 

-with io.open(DEF_FILE, encoding='utf-8') as deff:
-    defs = json.load(deff)
+from helper import get_testcases
+defs = get_testcases()
+

 with io.open(PARAMETERS_FILE, encoding='utf-8') as pf:
     parameters = json.load(pf)
 
 with io.open(PARAMETERS_FILE, encoding='utf-8') as pf:
     parameters = json.load(pf)
 


@@ -67,28 +71,29 @@ class TestDownload(unittest.TestCase):
 def generator(test_case):
 
     def test_template(self):
 def generator(test_case):
 
     def test_template(self):

-        ie = youtube_dl.InfoExtractors.get_info_extractor(test_case['name'])
+        ie = youtube_dl.extractor.get_info_extractor(test_case['name'])
+        def print_skipping(reason):
+            print('Skipping %s: %s' % (test_case['name'], reason))

         if not ie._WORKING:
         if not ie._WORKING:

-            print('Skipping: IE marked as not _WORKING')
+            print_skipping('IE marked as not _WORKING')

             return
         if 'playlist' not in test_case and not test_case['file']:
             return
         if 'playlist' not in test_case and not test_case['file']:

-            print('Skipping: No output file specified')
+            print_skipping('No output file specified')

             return
         if 'skip' in test_case:
             return
         if 'skip' in test_case:

-            print('Skipping: {0}'.format(test_case['skip']))
+            print_skipping(test_case['skip'])

             return
 
         params = self.parameters.copy()
         params.update(test_case.get('params', {}))
 
             return
 
         params = self.parameters.copy()
         params.update(test_case.get('params', {}))
 

-        fd = FileDownloader(params)
-        for ie in youtube_dl.InfoExtractors.gen_extractors():
-            fd.add_info_extractor(ie)
+        ydl = YoutubeDL(params)
+        ydl.add_default_info_extractors()

         finished_hook_called = set()
         def _hook(status):
             if status['status'] == 'finished':
                 finished_hook_called.add(status['filename'])
         finished_hook_called = set()
         def _hook(status):
             if status['status'] == 'finished':
                 finished_hook_called.add(status['filename'])

-        fd.add_progress_hook(_hook)
+        ydl.fd.add_progress_hook(_hook)

 
         test_cases = test_case.get('playlist', [test_case])
         for tc in test_cases:
 
         test_cases = test_case.get('playlist', [test_case])
         for tc in test_cases:


@@ -98,7 +103,7 @@ def generator(test_case):
         try:
             for retry in range(1, RETRIES + 1):
                 try:
         try:
             for retry in range(1, RETRIES + 1):
                 try:

-                    fd.download([test_case['url']])
+                    ydl.download([test_case['url']])

                 except (DownloadError, ExtractorError) as err:
                     if retry == RETRIES: raise
 
                 except (DownloadError, ExtractorError) as err:
                     if retry == RETRIES: raise
 


@@ -120,8 +125,24 @@ def generator(test_case):
                     self.assertEqual(md5_for_file, tc['md5'])
                 with io.open(tc['file'] + '.info.json', encoding='utf-8') as infof:
                     info_dict = json.load(infof)
                     self.assertEqual(md5_for_file, tc['md5'])
                 with io.open(tc['file'] + '.info.json', encoding='utf-8') as infof:
                     info_dict = json.load(infof)

-                for (info_field, value) in tc.get('info_dict', {}).items():
-                    self.assertEqual(value, info_dict.get(info_field))
+                for (info_field, expected) in tc.get('info_dict', {}).items():
+                    if isinstance(expected, compat_str) and expected.startswith('md5:'):
+                        got = 'md5:' + md5(info_dict.get(info_field))
+                    else:
+                        got = info_dict.get(info_field)
+                    self.assertEqual(expected, got,
+                        u'invalid value for field %s, expected %r, got %r' % (info_field, expected, got))
+
+                # If checkable fields are missing from the test case, print the info_dict
+                test_info_dict = dict((key, value if not isinstance(value, compat_str) or len(value) < 250 else 'md5:' + md5(value))
+                    for key, value in info_dict.items()
+                    if value and key in ('title', 'description', 'uploader', 'upload_date', 'uploader_id', 'location'))
+                if not all(key in tc.get('info_dict', {}).keys() for key in test_info_dict.keys()):
+                    sys.stderr.write(u'\n"info_dict": ' + json.dumps(test_info_dict, ensure_ascii=False, indent=2) + u'\n')
+
+                # Check for the presence of mandatory fields
+                for key in ('id', 'url', 'title', 'ext'):
+                    self.assertTrue(key in info_dict.keys() and info_dict[key])

         finally:
             for tc in test_cases:
                 _try_rm(tc['file'])
         finally:
             for tc in test_cases:
                 _try_rm(tc['file'])


@@ -131,9 +152,14 @@ def generator(test_case):
     return test_template
 
 ### And add them to TestDownload
     return test_template
 
 ### And add them to TestDownload

-for test_case in defs:
+for n, test_case in enumerate(defs):

     test_method = generator(test_case)
     test_method = generator(test_case)

-    test_method.__name__ = "test_{0}".format(test_case["name"])
+    tname = 'test_' + str(test_case['name'])
+    i = 1
+    while hasattr(TestDownload, tname):
+        tname = 'test_'  + str(test_case['name']) + '_' + str(i)
+        i += 1
+    test_method.__name__ = tname

     setattr(TestDownload, test_method.__name__, test_method)
     del test_method
 
     setattr(TestDownload, test_method.__name__, test_method)
     del test_method