Annotate changelog with bug being closed.

[youtubedl] / youtube_dl / extractor / livestream.py

diff --git a/youtube_dl/extractor/livestream.py b/youtube_dl/extractor/livestream.py
index 38fb3d9e4166f5f4a188ab2436c27240a8b04283..317ebbc4ee60d17051574ae05b8575526216de05 100644 (file)
--- a/youtube_dl/extractor/livestream.py
+++ b/youtube_dl/extractor/livestream.py
@@ -14,6 +14,7 @@ from ..utils import (
     xpath_with_ns,
     xpath_text,
     orderedSet,
     xpath_with_ns,
     xpath_text,
     orderedSet,

+    update_url_query,

     int_or_none,
     float_or_none,
     parse_iso8601,
     int_or_none,
     float_or_none,
     parse_iso8601,


@@ -36,7 +37,7 @@ class LivestreamIE(InfoExtractor):
             'duration': 5968.0,
             'like_count': int,
             'view_count': int,
             'duration': 5968.0,
             'like_count': int,
             'view_count': int,

-            'thumbnail': 're:^http://.*\.jpg$'
+            'thumbnail': r're:^http://.*\.jpg$'

         }
     }, {
         'url': 'http://new.livestream.com/tedx/cityenglish',
         }
     }, {
         'url': 'http://new.livestream.com/tedx/cityenglish',


@@ -64,7 +65,7 @@ class LivestreamIE(InfoExtractor):
     def _parse_smil_formats(self, smil, smil_url, video_id, namespace=None, f4m_params=None, transform_rtmp_url=None):
         base_ele = find_xpath_attr(
             smil, self._xpath_ns('.//meta', namespace), 'name', 'httpBase')
     def _parse_smil_formats(self, smil, smil_url, video_id, namespace=None, f4m_params=None, transform_rtmp_url=None):
         base_ele = find_xpath_attr(
             smil, self._xpath_ns('.//meta', namespace), 'name', 'httpBase')

-        base = base_ele.get('content') if base_ele else 'http://livestreamvod-f.akamaihd.net/'
+        base = base_ele.get('content') if base_ele is not None else 'http://livestreamvod-f.akamaihd.net/'

 
         formats = []
         video_nodes = smil.findall(self._xpath_ns('.//video', namespace))
 
         formats = []
         video_nodes = smil.findall(self._xpath_ns('.//video', namespace))


@@ -72,7 +73,10 @@ class LivestreamIE(InfoExtractor):
         for vn in video_nodes:
             tbr = int_or_none(vn.attrib.get('system-bitrate'), 1000)
             furl = (
         for vn in video_nodes:
             tbr = int_or_none(vn.attrib.get('system-bitrate'), 1000)
             furl = (

-                '%s%s?v=3.0.3&fp=WIN%%2014,0,0,145' % (base, vn.attrib['src']))
+                update_url_query(compat_urlparse.urljoin(base, vn.attrib['src']), {
+                    'v': '3.0.3',
+                    'fp': 'WIN% 14,0,0,145',
+                }))

             if 'clipBegin' in vn.attrib:
                 furl += '&ssek=' + vn.attrib['clipBegin']
             formats.append({
             if 'clipBegin' in vn.attrib:
                 furl += '&ssek=' + vn.attrib['clipBegin']
             formats.append({


@@ -115,7 +119,8 @@ class LivestreamIE(InfoExtractor):
         m3u8_url = video_data.get('m3u8_url')
         if m3u8_url:
             formats.extend(self._extract_m3u8_formats(
         m3u8_url = video_data.get('m3u8_url')
         if m3u8_url:
             formats.extend(self._extract_m3u8_formats(

-                m3u8_url, video_id, 'mp4', 'm3u8_native', m3u8_id='hls', fatal=False))
+                m3u8_url, video_id, 'mp4', 'm3u8_native',
+                m3u8_id='hls', fatal=False))

 
         f4m_url = video_data.get('f4m_url')
         if f4m_url:
 
         f4m_url = video_data.get('f4m_url')
         if f4m_url:


@@ -146,7 +151,7 @@ class LivestreamIE(InfoExtractor):
         }
 
     def _extract_stream_info(self, stream_info):
         }
 
     def _extract_stream_info(self, stream_info):

-        broadcast_id = stream_info['broadcast_id']
+        broadcast_id = compat_str(stream_info['broadcast_id'])

         is_live = stream_info.get('is_live')
 
         formats = []
         is_live = stream_info.get('is_live')
 
         formats = []


@@ -154,11 +159,11 @@ class LivestreamIE(InfoExtractor):
         if smil_url:
             formats.extend(self._extract_smil_formats(smil_url, broadcast_id))
 
         if smil_url:
             formats.extend(self._extract_smil_formats(smil_url, broadcast_id))
 

-        entry_protocol = 'm3u8' if is_live else 'm3u8_native'

         m3u8_url = stream_info.get('m3u8_url')
         if m3u8_url:
             formats.extend(self._extract_m3u8_formats(
         m3u8_url = stream_info.get('m3u8_url')
         if m3u8_url:
             formats.extend(self._extract_m3u8_formats(

-                m3u8_url, broadcast_id, 'mp4', entry_protocol, m3u8_id='hls', fatal=False))
+                m3u8_url, broadcast_id, 'mp4', 'm3u8_native',
+                m3u8_id='hls', fatal=False))

 
         rtsp_url = stream_info.get('rtsp_url')
         if rtsp_url:
 
         rtsp_url = stream_info.get('rtsp_url')
         if rtsp_url:


@@ -199,9 +204,10 @@ class LivestreamIE(InfoExtractor):
             if not videos_info:
                 break
             for v in videos_info:
             if not videos_info:
                 break
             for v in videos_info:

+                v_id = compat_str(v['id'])

                 entries.append(self.url_result(
                 entries.append(self.url_result(

-                    'http://livestream.com/accounts/%s/events/%s/videos/%s' % (account_id, event_id, v['id']),
-                    'Livestream', v['id'], v['caption']))
+                    'http://livestream.com/accounts/%s/events/%s/videos/%s' % (account_id, event_id, v_id),
+                    'Livestream', v_id, v.get('caption')))

             last_video = videos_info[-1]['id']
         return self.playlist_result(entries, event_id, event_data['full_name'])
 
             last_video = videos_info[-1]['id']
         return self.playlist_result(entries, event_id, event_data['full_name'])
 


@@ -271,7 +277,7 @@ class LivestreamOriginalIE(InfoExtractor):
             'view_count': view_count,
         }
 
             'view_count': view_count,
         }
 

-    def _extract_video_formats(self, video_data, video_id, entry_protocol):
+    def _extract_video_formats(self, video_data, video_id):

         formats = []
 
         progressive_url = video_data.get('progressiveUrl')
         formats = []
 
         progressive_url = video_data.get('progressiveUrl')


@@ -284,7 +290,8 @@ class LivestreamOriginalIE(InfoExtractor):
         m3u8_url = video_data.get('httpUrl')
         if m3u8_url:
             formats.extend(self._extract_m3u8_formats(
         m3u8_url = video_data.get('httpUrl')
         if m3u8_url:
             formats.extend(self._extract_m3u8_formats(

-                m3u8_url, video_id, 'mp4', entry_protocol, m3u8_id='hls', fatal=False))
+                m3u8_url, video_id, 'mp4', 'm3u8_native',
+                m3u8_id='hls', fatal=False))

 
         rtsp_url = video_data.get('rtspUrl')
         if rtsp_url:
 
         rtsp_url = video_data.get('rtspUrl')
         if rtsp_url:


@@ -331,15 +338,14 @@ class LivestreamOriginalIE(InfoExtractor):
                 info = {
                     'title': self._og_search_title(webpage),
                     'description': self._og_search_description(webpage),
                 info = {
                     'title': self._og_search_title(webpage),
                     'description': self._og_search_description(webpage),

-                    'thumbnail': self._search_regex(r'channelLogo.src\s*=\s*"([^"]+)"', webpage, 'thumbnail', None),
+                    'thumbnail': self._search_regex(r'channelLogo\.src\s*=\s*"([^"]+)"', webpage, 'thumbnail', None),

                 }
             video_data = self._download_json(stream_url, content_id)
             is_live = video_data.get('isLive')
                 }
             video_data = self._download_json(stream_url, content_id)
             is_live = video_data.get('isLive')

-            entry_protocol = 'm3u8' if is_live else 'm3u8_native'

             info.update({
                 'id': content_id,
                 'title': self._live_title(info['title']) if is_live else info['title'],
             info.update({
                 'id': content_id,
                 'title': self._live_title(info['title']) if is_live else info['title'],

-                'formats': self._extract_video_formats(video_data, content_id, entry_protocol),
+                'formats': self._extract_video_formats(video_data, content_id),

                 'is_live': is_live,
             })
             return info
                 'is_live': is_live,
             })
             return info