Tidy up cleanup rule and keep lintian happy.

[youtubedl] / youtube_dl / extractor / fc2.py

diff --git a/youtube_dl/extractor/fc2.py b/youtube_dl/extractor/fc2.py
index 1ccc1a9642bb09ed84bdd2747c665520ab3c98c4..c7d69ff1f980de46bd4ecce96e4ac301b1f1be59 100644 (file)
--- a/youtube_dl/extractor/fc2.py
+++ b/youtube_dl/extractor/fc2.py
@@ -5,17 +5,18 @@ import hashlib
 
 from .common import InfoExtractor
 from ..compat import (
 
 from .common import InfoExtractor
 from ..compat import (

-    compat_urllib_parse,

     compat_urllib_request,
     compat_urlparse,
 )
 from ..utils import (
     ExtractorError,
     compat_urllib_request,
     compat_urlparse,
 )
 from ..utils import (
     ExtractorError,

+    sanitized_Request,
+    urlencode_postdata,

 )
 
 
 class FC2IE(InfoExtractor):
 )
 
 
 class FC2IE(InfoExtractor):

-    _VALID_URL = r'^http://video\.fc2\.com/(?:[^/]+/)?content/(?P<id>[^/]+)'
+    _VALID_URL = r'^https?://video\.fc2\.com/(?:[^/]+/)*content/(?P<id>[^/]+)'

     IE_NAME = 'fc2'
     _NETRC_MACHINE = 'fc2'
     _TESTS = [{
     IE_NAME = 'fc2'
     _NETRC_MACHINE = 'fc2'
     _TESTS = [{


@@ -35,8 +36,11 @@ class FC2IE(InfoExtractor):
         'params': {
             'username': 'ytdl@yt-dl.org',
             'password': '(snip)',
         'params': {
             'username': 'ytdl@yt-dl.org',
             'password': '(snip)',

-            'skip': 'requires actual password'
-        }
+        },
+        'skip': 'requires actual password',
+    }, {
+        'url': 'http://video.fc2.com/en/a/content/20130926eZpARwsF',
+        'only_matching': True,

     }]
 
     def _login(self):
     }]
 
     def _login(self):


@@ -52,11 +56,8 @@ class FC2IE(InfoExtractor):
             'Submit': ' Login ',
         }
 
             'Submit': ' Login ',
         }
 

-        # Convert to UTF-8 *before* urlencode because Python 2.x's urlencode
-        # chokes on unicode
-        login_form = dict((k.encode('utf-8'), v.encode('utf-8')) for k, v in login_form_strs.items())
-        login_data = compat_urllib_parse.urlencode(login_form).encode('utf-8')
-        request = compat_urllib_request.Request(
+        login_data = urlencode_postdata(login_form_strs)
+        request = sanitized_Request(

             'https://secure.id.fc2.com/index.php?mode=login&switch_language=en', login_data)
 
         login_results = self._download_webpage(request, None, note='Logging in', errnote='Unable to log in')
             'https://secure.id.fc2.com/index.php?mode=login&switch_language=en', login_data)
 
         login_results = self._download_webpage(request, None, note='Logging in', errnote='Unable to log in')


@@ -65,7 +66,7 @@ class FC2IE(InfoExtractor):
             return False
 
         # this is also needed
             return False
 
         # this is also needed

-        login_redir = compat_urllib_request.Request('http://id.fc2.com/?mode=redirect&login=done')
+        login_redir = sanitized_Request('http://id.fc2.com/?mode=redirect&login=done')

         self._download_webpage(
             login_redir, None, note='Login redirect', errnote='Login redirect failed')
 
         self._download_webpage(
             login_redir, None, note='Login redirect', errnote='Login redirect failed')
 


@@ -80,13 +81,13 @@ class FC2IE(InfoExtractor):
 
         title = self._og_search_title(webpage)
         thumbnail = self._og_search_thumbnail(webpage)
 
         title = self._og_search_title(webpage)
         thumbnail = self._og_search_thumbnail(webpage)

-        refer = url.replace('/content/', '/a/content/')
+        refer = url.replace('/content/', '/a/content/') if '/a/content/' not in url else url

 
         mimi = hashlib.md5((video_id + '_gGddgPfeaf_gzyr').encode('utf-8')).hexdigest()
 
         info_url = (
 
         mimi = hashlib.md5((video_id + '_gGddgPfeaf_gzyr').encode('utf-8')).hexdigest()
 
         info_url = (

-            "http://video.fc2.com/ginfo.php?mimi={1:s}&href={2:s}&v={0:s}&fversion=WIN%2011%2C6%2C602%2C180&from=2&otag=0&upid={0:s}&tk=null&".
-            format(video_id, mimi, compat_urllib_request.quote(refer, safe='').replace('.', '%2E')))
+            'http://video.fc2.com/ginfo.php?mimi={1:s}&href={2:s}&v={0:s}&fversion=WIN%2011%2C6%2C602%2C180&from=2&otag=0&upid={0:s}&tk=null&'.
+            format(video_id, mimi, compat_urllib_request.quote(refer, safe=b'').replace('.', '%2E')))

 
         info_webpage = self._download_webpage(
             info_url, video_id, note='Downloading info page')
 
         info_webpage = self._download_webpage(
             info_url, video_id, note='Downloading info page')