debian/changelog: Annotate bugs to close.

[youtubedl] / youtube_dl / extractor / novamov.py

diff --git a/youtube_dl/extractor/novamov.py b/youtube_dl/extractor/novamov.py
index 48ee00da3dbc0c75a5a5b09c8d7b2faf7e0a6ceb..04d779890af1960d65b070d0b2f80e429db21d07 100644 (file)
--- a/youtube_dl/extractor/novamov.py
+++ b/youtube_dl/extractor/novamov.py
@@ -3,54 +3,63 @@ from __future__ import unicode_literals
 import re
 
 from .common import InfoExtractor
 import re
 
 from .common import InfoExtractor

+from ..compat import (
+    compat_urlparse,
+)

 from ..utils import (
     ExtractorError,
 from ..utils import (
     ExtractorError,

-    compat_urlparse

 )
 
 
 )
 
 

-class NovamovIE(InfoExtractor):
-    _VALID_URL = r'http://(?:(?:www\.)?novamov\.com/video/|(?:(?:embed|www)\.)novamov\.com/embed\.php\?v=)(?P<videoid>[a-z\d]{13})'
+class NovaMovIE(InfoExtractor):
+    IE_NAME = 'novamov'
+    IE_DESC = 'NovaMov'
+
+    _VALID_URL_TEMPLATE = r'http://(?:(?:www\.)?%(host)s/(?:file|video)/|(?:(?:embed|www)\.)%(host)s/embed\.php\?(?:.*?&)?v=)(?P<id>[a-z\d]{13})'
+    _VALID_URL = _VALID_URL_TEMPLATE % {'host': 'novamov\.com'}
+
+    _HOST = 'www.novamov.com'
+
+    _FILE_DELETED_REGEX = r'This file no longer exists on our servers!</h2>'
+    _FILEKEY_REGEX = r'flashvars\.filekey="(?P<filekey>[^"]+)";'
+    _TITLE_REGEX = r'(?s)<div class="v_tab blockborder rounded5" id="v_tab1">\s*<h3>([^<]+)</h3>'
+    _DESCRIPTION_REGEX = r'(?s)<div class="v_tab blockborder rounded5" id="v_tab1">\s*<h3>[^<]+</h3><p>([^<]+)</p>'

 
     _TEST = {
         'url': 'http://www.novamov.com/video/4rurhn9x446jj',
 
     _TEST = {
         'url': 'http://www.novamov.com/video/4rurhn9x446jj',

-        'file': '4rurhn9x446jj.flv',

         'md5': '7205f346a52bbeba427603ba10d4b935',
         'info_dict': {
         'md5': '7205f346a52bbeba427603ba10d4b935',
         'info_dict': {

+            'id': '4rurhn9x446jj',
+            'ext': 'flv',

             'title': 'search engine optimization',
             'description': 'search engine optimization is used to rank the web page in the google search engine'
             'title': 'search engine optimization',
             'description': 'search engine optimization is used to rank the web page in the google search engine'

-        }
+        },
+        'skip': '"Invalid token" errors abound (in web interface as well as youtube-dl, there is nothing we can do about it.)'

     }
 
     def _real_extract(self, url):
         mobj = re.match(self._VALID_URL, url)
     }
 
     def _real_extract(self, url):
         mobj = re.match(self._VALID_URL, url)

-        video_id = mobj.group('videoid')
-
-        page = self._download_webpage('http://www.novamov.com/video/%s' % video_id,
-                                      video_id, 'Downloading video page')
+        video_id = mobj.group('id')

 
 

-        if re.search(r'This file no longer exists on our servers!</h2>', page) is not None:
-            raise ExtractorError(u'Video %s does not exist' % video_id, expected=True)
+        page = self._download_webpage(
+            'http://%s/video/%s' % (self._HOST, video_id), video_id, 'Downloading video page')

 
 

-        filekey = self._search_regex(
-            r'flashvars\.filekey="(?P<filekey>[^"]+)";', page, 'filekey')
+        if re.search(self._FILE_DELETED_REGEX, page) is not None:
+            raise ExtractorError('Video %s does not exist' % video_id, expected=True)

 
 

-        title = self._html_search_regex(
-            r'(?s)<div class="v_tab blockborder rounded5" id="v_tab1">\s*<h3>([^<]+)</h3>',
-            page, 'title', fatal=False)
+        filekey = self._search_regex(self._FILEKEY_REGEX, page, 'filekey')

 
 

-        description = self._html_search_regex(
-            r'(?s)<div class="v_tab blockborder rounded5" id="v_tab1">\s*<h3>[^<]+</h3><p>([^<]+)</p>',
-            page, 'description', fatal=False)
+        title = self._html_search_regex(self._TITLE_REGEX, page, 'title', fatal=False)
+        description = self._html_search_regex(self._DESCRIPTION_REGEX, page, 'description', default='', fatal=False)

 
         api_response = self._download_webpage(
 
         api_response = self._download_webpage(

-            'http://www.novamov.com/api/player.api.php?key=%s&file=%s' % (filekey, video_id),
-            video_id, 'Downloading video api response')
+            'http://%s/api/player.api.php?key=%s&file=%s' % (self._HOST, filekey, video_id), video_id,
+            'Downloading video api response')

 
         response = compat_urlparse.parse_qs(api_response)
 
         if 'error_msg' in response:
 
         response = compat_urlparse.parse_qs(api_response)
 
         if 'error_msg' in response:

-            raise ExtractorError('novamov returned error: %s' % response['error_msg'][0], expected=True)
+            raise ExtractorError('%s returned error: %s' % (self.IE_NAME, response['error_msg'][0]), expected=True)

 
         video_url = response['url'][0]
 
 
         video_url = response['url'][0]