Add todo about new symfony 4.4 getPublicDir bundle member function

[packbundle] / Asset / PathPackage.php

diff --git a/Asset/PathPackage.php b/Asset/PathPackage.php
index 371ffccf9be42c04d76bebd02258adc564a11724..1a975c5e9e6cc5bf6dae3346a070346529d7fb26 100644 (file)
--- a/Asset/PathPackage.php
+++ b/Asset/PathPackage.php
@@ -31,18 +31,21 @@ class PathPackage extends BasePackage {
        }
 
        /**
+        * @todo Try retrive public dir from the member function BundleNameBundle::getPublicDir() return value ?
+        * @xxx see https://symfony.com/doc/current/bundles.html#overridding-the-bundle-directory-structure
         * {@inheritdoc}
         */
        public function getUrl($path) {
                //Match url starting with a bundle name
-               if (preg_match('%^@([A-Z][a-zA-Z]*)Bundle/Resources/public(/.*)$%', $path, $matches)) {
+               if (preg_match('%^@([A-Z][a-zA-Z]*?)(?:Bundle/Resources/public)?/(.*)$%', $path, $matches)) {
                        //Handle empty or without replacement pattern basePath
                        if (empty($this->basePath) || strpos($this->basePath, '%s') === false) {
                                //Set path from hardcoded format
-                               $path = '/bundles/'.strtolower($matches[1]).$matches[2];
+                               $path = '/bundles/'.strtolower($matches[1]).'/'.$matches[2];
                        //Proceed with basePath pattern replacement
                        } else {
                                //Set path from basePath pattern
+                               //XXX: basePath has a trailing / added by constructor
                                $path = sprintf($this->basePath, strtolower($matches[1])).$matches[2];
                        }
                }